Merged
Conversation
when content encoding is gzipped even for 500s, unzip the response. also adds tests.
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
volmedo
reviewed
Dec 1, 2025
Member
volmedo
left a comment
volmedo
left a comment
There was a problem hiding this comment.
This works, but handling gzip manually in the client is not needed.
I wrote this PR that target yours: #281. There, I removed the gzip-related code to use the built-in support and the tests still pass. PTAL and let me know what you think.
alanshaw
approved these changes
Dec 1, 2025
Go's HTTP client in the standard library supports gzip automatically when one doesn't set the `Accept-Encoding: gzip` header. If the header is not set, the client will do it automatically (unless it's disabled in the underlying transport) and will also handle compression/decompression internally. I removed the code setting the `Accept-Encoding` header and also manual comp/decomp and the implementation still passes the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when content encoding is gzipped even for 500s, unzip the response. also adds tests for gzipped encoding