Fix api.js in typescript version#40
Merged
alanshaw merged 10 commits intostoracha:mainfrom Apr 4, 2025
Merged
Conversation
jchris
reviewed
Mar 20, 2025
| import { Link, UnknownLink, BlockView, Block, Version } from 'multiformats' | ||
| import type { Version } from 'multiformats' | ||
| import type { Link, UnknownLink } from 'multiformats/link/interface' | ||
| import type { Block, BlockView } from 'multiformats/block/interface' |
alanshaw
previously approved these changes
Apr 2, 2025
alanshaw
requested changes
Apr 2, 2025
Member
alanshaw
left a comment
There was a problem hiding this comment.
Please could you resolve the build errors?
Contributor
Author
|
thx --- i will look into it --- thx for enabling the CI |
Contributor
Author
|
@alanshaw, Sorry for not building on my side before --- I just forgot to double-check. I now removed the src tree from the published artifact and installed these scripts:
|
Member
|
Can you fix the new lockfile issue in CI? |
Contributor
Author
|
i'm so used to have a working CI on every commit --- so i missed to commit the changed pnpm.lock |
Member
|
@mabels we can probably drop Node.js 18 (seeing as it is EOL at the end of the month) and add 22. |
Contributor
Author
|
@alanshaw I left the node 18 test but improved the root cause: it's not nice, but working(hopefully) |
alanshaw
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I got this error:
this was happening because, besides api.js, the .d.ts was not in the same directory, which confused tsx.
To fix it I changed the exports in package.json and the emitRule of tsc to only use the emitted file structure.
SideTrack:
I updated the package.json, and with that, the test infra to use vitest. I hope that is not a problem --
if you want to stick with mocha and coverage -> I am not happy but could rewind -> but than the
typescript is required to the test infra -> due to the removal of the api.js which causes this problem in the
first place.
I run standard --fix, which also fixes the formatting that's why so much files.