fix: joining blob path to PDP public URL#182
Merged
alanshaw merged 2 commits intofix/join-http-path-to-multiaddrfrom Aug 12, 2025
Merged
fix: joining blob path to PDP public URL#182alanshaw merged 2 commits intofix/join-http-path-to-multiaddrfrom
alanshaw merged 2 commits intofix/join-http-path-to-multiaddrfrom
Conversation
volmedo
approved these changes
Aug 11, 2025
frrist
approved these changes
Aug 11, 2025
| @@ -0,0 +1,46 @@ | |||
| package mahttp | |||
Member
There was a problem hiding this comment.
How would we feel about putting this in lib/ instead of it's own mahttp package?
Member
Author
There was a problem hiding this comment.
There is not a lib/ directory...
Member
There was a problem hiding this comment.
Whoops, you're right one doesn't exist yet. Would you mind creating one and moving this logic there? Over in #169 I have done something similar - defined a lib/ dir and started moving common logic over to it.
Member
Author
There was a problem hiding this comment.
yes but this is not a directory in the "standard"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, targets: #180
joinHTTPPathto a package that can be used everywhere.piece/{blobCID}to the public curio multiaddr.TrimSuffixfrom #176 as it is not needed.