Open
Conversation
- somewhat inaccurate since the tests don't yet use the container built in CI
Add //go:build e2e tag to smelt tests so they are excluded from `go test ./...`. Developers can run them explicitly with `make test-e2e`. In CI, e2e tests now run only after unit tests pass.
alanshaw
approved these changes
Apr 2, 2026
Member
alanshaw
left a comment
alanshaw
left a comment
There was a problem hiding this comment.
This is awesome, lets get this in and iterate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.