fix: deploy to different networks properly#17
Merged
Conversation
volmedo
force-pushed
the
vic/fix/proper-network-deployment
branch
from
cacb766 to
ba1a0ef
Compare
alanshaw
approved these changes
Jun 19, 2025
| # hasn't been deployed yet or it was deleted). The reference to the revision makes this data block dependent on | ||
| # the find task existing. See https://github.com/hashicorp/terraform-provider-aws/pull/10247 | ||
| task_definition = var.find_task.revision ? var.find_task.family : var.find_task.family | ||
| task_definition = var.find_task.revision != null ? var.find_task.family : var.find_task.family |
Member
There was a problem hiding this comment.
lol, I mean sure it's already weird...
Co-authored-by: ash <alan138@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The deployment configuration in this project didn't have proper support for different networks. A good example is that only one DNS zone was being created, but each network will require its own. That caused workspaces targeting different networks to compete for the same set of shared resources.
Proposed Changes
I added network support to storoku in storacha/storoku#6 and then upgraded here.
Tests
I actually used this repo to test the changes being introduced in storoku while adding support for networks there. With the new deployment config, I was able to deploy shared resources and also hot staging and prod and warm staging and all deployments completed successfully.