Conversation
alanshaw
approved these changes
May 7, 2025
Member
alanshaw
left a comment
There was a problem hiding this comment.
This LGTM although i can't really speak to the phony tofu init - do we really want to run these every time? What if a new target instead that forces?
Member
Author
|
you are right. I looked for dependencies on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when I ran
make initfrom my clean environment as the first step to deploy my dev env, I was presented with a message fromtofu initbecause I hadTF_WORKSPACE=vicin my.env.terraformfile but the workspace didn't exist yet. I think the solution is to forceTF_WORKSPACE=defaultin the init for theappfolder too, as is done with thesharedfolder.I also added
.PHONYtargets for the init tasks so that they are always run. There are some situations where modules need to be updated and a new init is required.