Skip to content

Comments

fix: typo and minor improvements#1

Merged
volmedo merged 3 commits intomainfrom
vic/fix/minor-fixes
May 8, 2025
Merged

fix: typo and minor improvements#1
volmedo merged 3 commits intomainfrom
vic/fix/minor-fixes

Conversation

@volmedo
Copy link
Member

@volmedo volmedo commented May 6, 2025

when I ran make init from my clean environment as the first step to deploy my dev env, I was presented with a message from tofu init because I had TF_WORKSPACE=vic in my .env.terraform file but the workspace didn't exist yet. I think the solution is to force TF_WORKSPACE=default in the init for the app folder too, as is done with the shared folder.

I also added .PHONY targets for the init tasks so that they are always run. There are some situations where modules need to be updated and a new init is required.

@volmedo volmedo requested a review from hannahhoward May 6, 2025 17:01
@volmedo volmedo self-assigned this May 6, 2025
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM although i can't really speak to the phony tofu init - do we really want to run these every time? What if a new target instead that forces?

@volmedo
Copy link
Member Author

volmedo commented May 7, 2025

you are right. I looked for dependencies on init and didn't realise other tasks depend directly on app/.terraform. I'm removing the phoniness for now.

@volmedo volmedo merged commit ad8dd94 into main May 8, 2025
4 checks passed
@volmedo volmedo deleted the vic/fix/minor-fixes branch May 8, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants