fix(upload-api): On index fetch fail, really fail#532
Open
Conversation
alanshaw
approved these changes
Nov 3, 2025
Member
alanshaw
left a comment
alanshaw
left a comment
There was a problem hiding this comment.
This LGTM but I don't think you should be hitting this code in the warm storage network.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't silently accept failures to fetch the index.
NB: This eventually puts the error message into the response to
space/index/add. Is this leaking too much info? It's certainly convenient, but perhaps we should log to console and return something more generic. That should maybe be handled a level above this code, though.