Skip to content

text: Provide clearer user prompts when requesting authorization. #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

text: Provide clearer user prompts when requesting authorization. #1363

wants to merge 1 commit into from

Conversation

itsXuSt
Copy link

@itsXuSt itsXuSt commented Mar 10, 2025

#1362
@tbzatek please check this PR if this modification is acceptable. Thank you.

@itsXuSt itsXuSt force-pushed the master branch 2 times, most recently from c28f40d to 6199dc6 Compare March 10, 2025 03:45
@itsXuSt itsXuSt changed the title text: more cleariy user prompt when ask for authoration text: Provide clearer user prompts when requesting authorization. Mar 10, 2025
siteshwar
siteshwar reviewed Mar 10, 2025
View reviewed changes
@itsXuSt itsXuSt force-pushed the master branch 4 times, most recently from 1c45bd8 to 09adc8b Compare March 10, 2025 05:47
@tbzatek
Copy link
Member

tbzatek commented Mar 10, 2025

Besides still discussing details in #1362, I wonder how we should handle po file updates. Translations are handled and automated by the GNOME Project Translation Platform. Ideally we would update the pot file and let the system process all languages. Not sure how this works exactly though, only updated translations are being pushed in the git repo.

@itsXuSt itsXuSt force-pushed the master branch 3 times, most recently from f52584a to bde1f22 Compare March 12, 2025 07:03
@itsXuSt itsXuSt marked this pull request as draft March 12, 2025 07:39
@itsXuSt itsXuSt mentioned this pull request Mar 13, 2025
Open
@itsXuSt itsXuSt marked this pull request as ready for review March 13, 2025 02:17
@itsXuSt
Copy link
Author

itsXuSt commented Mar 13, 2025

/check

@itsXuSt
Copy link
Author

itsXuSt commented Mar 13, 2025

/checks

tbzatek
tbzatek reviewed Mar 19, 2025
View reviewed changes
Copy link
Member

@tbzatek tbzatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of details, the concept looks good however.

@tbzatek
Copy link
Member

tbzatek commented Mar 19, 2025

Jenkins, ok to test.

@itsXuSt
Copy link
Author

itsXuSt commented Mar 24, 2025

Hi @tbzatek , it has been modified according to your comments, please review again, thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siteshwar siteshwar siteshwar left review comments

@tbzatek tbzatek tbzatek left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsXuSt @tbzatek @siteshwar