lvm2: Prevent a segfault on discarded probe output #1453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 28c3978 brought a possible NULL-dereference and some memleaks. Hard to hit in real world, difficult to debug. #0 0x00007fe74823badd in vgs_pvs_data_free () at ../udisks/modules/libudisks2_lvm2.so storaged-project#1 0x00007fe74822e933 in lvm_update_vgs () at ..//udisks/modules/libudisks2_lvm2.so storaged-project#2 0x00007fe74ba0966c in g_task_return_now (task=0x1eded590 [GTask]) at ../gio/gtask.c:1363 storaged-project#3 0x00007fe74ba096a5 in complete_in_idle_cb (task=task@entry=0x1eded590) at ../gio/gtask.c:1377
vojtechtrefny
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 28c3978 brought a possible NULL-dereference and some memleaks. Hard to hit in real world, difficult to debug.