-
Notifications
You must be signed in to change notification settings - Fork 17
feat(nuxt)!: upgrade nuxt 4 #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updates the ref to work both with deep and shallow ref, and updates dedup values Breaking change: new default dir is `~/app/storyblok`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
maoberlehner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As we've discussed, you might consider making it backward compatible but I think a new major is okay too in this case.
|
|
||
| <template> | ||
| <main v-editable class="container mx-auto pt-24"> | ||
| <h2>{{ story?.content.title }}</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete optional chaining throws on undefined story
Medium Severity
The expression story?.content.title will throw a TypeError when story is undefined (e.g., on API error). The optional chaining ?. only protects the access to content, but if story is undefined, story?.content evaluates to undefined, and then accessing .title on undefined throws. Unlike other pages in the playground that use v-if="story" guards, this template directly renders the expression without protection. The pattern needs an additional ?. before title to be null-safe.
@storyblok/astro
storyblok
@storyblok/eslint-config
@storyblok/js
storyblok-js-client
@storyblok/management-api-client
@storyblok/nuxt
@storyblok/react
@storyblok/region-helper
@storyblok/richtext
@storyblok/svelte
@storyblok/vue
commit: |
Note
Nuxt 4 migration and ESM updates
@storyblok/nuxtto9.0.0, switches to ESM-only (exportstypes totypes.d.mts,main/importtomodule.mjs), and updates peer/dev dependencies to Nuxt^4.2.2.playground-e2e, migrates toapp/structure, updatesnuxt.config.ts(newcompatibilityDate), adjusts scripts/ports, and minor page fixes (error guards,#componentsimport, bridge options usage).Composable improvements (
src/runtime/composables/useAsyncStoryblok.ts)bridgeconfig and mirrorsapi.resolve_relations/resolve_linksto bridge (resolveRelations/resolveLinks).dataanderrorcan be null/undefined) and updatesdedupeunion.Misc
Written by Cursor Bugbot for commit 5296c67. This will update automatically on new commits. Configure here.