chore(repo): keep private repo details out of the public repo - #787
Draft
maoberlehner wants to merge 2 commits into
Draft
maoberlehner wants to merge 2 commits into
maoberlehner wants to merge 2 commits into
Conversation
The sibling-repo section named the private backend, frontend, and bridge repositories, described their internal layout, and pointed at specific paths -- in a file that ships publicly. Three other files leaked repository names the same way. The cross-repo context now lives in the private dx-workspace repo, which checks all projects out side by side. What stays here is the rule itself, phrased without naming anything: keep private repository details out of public-facing text. The docs-site conventions that were bundled into that section move to the `docs/` list where the rest of the docs guidance lives.
Restating the rule here meant restating what it protects: that private repositories exist and are adjacent enough to leak from. The workspace repo that checks all projects out side by side is the only place that both knows which repos are private and has any use for the rule, so it owns it outright.
@storyblok/angular
@storyblok/astro
@storyblok/api-client
storyblok
@storyblok/experiments
@storyblok/js
storyblok-js-client
@storyblok/lint-config
@storyblok/live-preview
@storyblok/management-api-client
@storyblok/migrations
@storyblok/nuxt
@storyblok/react
@storyblok/region-helper
@storyblok/richtext
@storyblok/schema
@storyblok/svelte
@storyblok/vue
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AGENTS.mdhad a Sibling repos section that named three private Storyblok repositories, summarized their internals, and pointed at specific paths inside them — in a file that ships in a public repo. Three other public files leaked repository names the same way: a skill instruction, an ADR, and a comment in an overlay spec.The section also carried the very rule it violated ("never reference these in public-facing text"), which made the contradiction easy to miss.
What changed
AGENTS.md, including the private-repo rule itself. Restating the rule here meant restating what it protects — that private repositories exist and are adjacent enough to leak from.docs/list, next to thedocs-platform.mdentry where the rest of the docs guidance already lives..agents/skills/spec/SKILL.md— "verify API contracts against the backend"adr/0011-…— "Verified against the backend"multilink-field-value.yaml— "the editor's anchor modal emitsnull…"rgfor the four repository names now returns nothing outside.git.Where the context went
The cross-repo context is now maintained in a private
dx-workspacerepo that checks all projects out side by side and holds a singleCLAUDE.md. Every fact removed here has an equivalent there:AGENTS.mddx-workspacepostMessageprotocol, editable-block attributes, overlay/click-to-edit, lifecycledocs/docs-platform.mdIMPORTANTstrength and an explicit list of which repos are publicbootstrap.shchecks all of them outVerification
pnpm nx run-many -t generate:openapi→ no diff underpackages/*/src/generated/. The spec change is a YAML comment, but the repo rule says regenerate every consumer after touchingtools/openapi-codegen/, so it was run.pnpm formatand the pre-commit lint pass clean.