This repository was archived by the owner on Jan 19, 2026. It is now read-only.
chore: updated the package.json detection and removed the STUB env var#194
Merged
Conversation
commit: |
alvarosabu
approved these changes
May 19, 2025
Contributor
alvarosabu
left a comment
alvarosabu
left a comment
There was a problem hiding this comment.
Hey @imranolas thanks a lot for solving this, I wasn't really happy with the stub workaround. I just modified the script to remove the stub there, I also tested:
npm run dev✅npm run buildand thennode dist/index.mjs✅
Everything seems to work so all good 👍
alvarosabu
added
the
p1-chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the package.json detection method to avoid needing the STUB variable. Now the runner executes the same regardless of whether the environment is stubbed, vitest, or built.