Merged
Conversation
ghengeveld
approved these changes
Dec 5, 2025
Member
|
@pocka Thanks for doing this! Would you consider this a patch, or is this a breaking change somehow? Please add the appropriate label 🙏 |
Collaborator
Author
|
Definetely not a breaking change / major. Honestly I'm not sure which, minor or patch, would be appropriate this case...
|
Member
|
Considering the UI is changed, I think this should be a minor update then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figspec v2 eliminates
litdependency (#245 (comment)). It also got accessibility improvements lately.I cannot test this due to the new ridiculous rate limit.
TypeScript compiles the source code without error, but whether runtime works is untested. THIS PULL REQUEST IS PROVIDED "AS IS".
Combined with their shift of strategy and priority in recent years, I will no longer touch this addon's figma/figspec integration. No more patch from me on these functionality. Don't ping me on Figma/figspec-related issues. Figspec the library (
@figspec/componentsand@figspec/react) will be maintained regardless of this.(for those who work on this)
The root
package.jsondepends on@storybook/addon-designs: "*"and it pulls in the latest published@storybook/addon-designs. As a result of this, you'll end up having two figspec versions, each@figspec/componentsand@figspec/react. If you see v1 UI after build, try temporarily puttingoverridestopnpm-workspace.yamland re-install the workspace.Do not forget to reset the change and re-install before commit.