Added configuration code that scours file path/tree for .swcrc file#9
Closed
jglanz wants to merge 1 commit intostorybookjs:mainfrom
Closed
Added configuration code that scours file path/tree for .swcrc file#9jglanz wants to merge 1 commit intostorybookjs:mainfrom
.swcrc file#9jglanz wants to merge 1 commit intostorybookjs:mainfrom
Conversation
…g directory tree for an `.swcrc` config file. If it finds one then it loads that file from disk and takes precidence over the code config
Contributor
|
Hi @jglanz Thank you for your contribution! Do you think this change is a breaking change and should hence be released as a major version? |
Member
|
Hey folks, Revisiting this PR as Storybook 9 is out and there would be a breaking change for this addon to be updated. I'm opening a PR for Storybook 9 and am including a revisited commit for this here PR: #19 I did not go ahead with exactly the commit provided here because I found a few blind spots:
@jglanz feel free to try it out and let me know if it fits your needs. Thanks, |
Member
|
The other PR is now merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added configuration code that scours file path/tree for
.swcrcfileIf it finds one then it loads that file from disk and takes precedence over the code config.
The simplest/clearest reason for this is
swcconfig breaking changes, for instance, I received this error (swc error env and jsc.target cannot be used together), which triggered this idea (and is resolved with this feature)