Handle Copilot review feedback

Author: ghengeveld

apps/internal-storybook/tests/mcp-composition.e2e.test.ts

@@ -14,6 +14,7 @@ const MCP_ENDPOINT = `http://localhost:${PORT}/mcp`;
 const STARTUP_TIMEOUT = 30_000;
 
 let storybookProcess: ReturnType<typeof x> | null = null;
+let hasRemoteSource = false;
 
 async function mcpRequest(method: string, params: any = {}) {
 	const response = await fetch(MCP_ENDPOINT, {
@@ -40,7 +41,7 @@ describe('MCP Composition E2E Tests', () => {
 			arguments: {},
 		});
 		const docsText = docsResponse.result.content[0].text as string;
-		expect(docsText).toContain('id: storybook-ui');
+		hasRemoteSource = docsText.includes('id: storybook-ui') || docsText.includes('# Storybook UI');
 	}, STARTUP_TIMEOUT);
 
 	afterAll(async () => {
@@ -68,8 +69,8 @@ describe('MCP Composition E2E Tests', () => {
 			// Local components should be present
 			expect(text).toContain('Button (example-button)');
 
-			// In single-source fallback mode, list-all-documentation returns one flat section.
-			expect(text).toContain('Components');
+			// Remote source output should include its own documentation sections.
+			expect(text).toContain('## Components');
 		});
 
 		it('should fetch documentation for a local component', async () => {
@@ -216,99 +217,28 @@ describe('MCP Composition E2E Tests', () => {
 				},
 			});
 
-			expect(response.result).toMatchInlineSnapshot(`
-				{
-				  "content": [
-				    {
-				      "text": "# Button
-
-				ID: example-button
-
-				Primary UI component for user interaction
-
-				## Stories
-
-				### Primary
-
-				Story ID: example-button--primary
-
-				\`\`\`
-				import { Button } from "@my-org/my-component-library";
-
-				const Primary = () => <Button onClick={fn()} primary label="Button" />;
-				\`\`\`
-
-				### Secondary
-
-				Story ID: example-button--secondary
-
-				\`\`\`
-				import { Button } from "@my-org/my-component-library";
-
-				const Secondary = () => <Button onClick={fn()} label="Button" />;
-				\`\`\`
-
-				### Large
-
-				Story ID: example-button--large
-
-				\`\`\`
-				import { Button } from "@my-org/my-component-library";
-
-				const Large = () => <Button onClick={fn()} size="large" label="Button" />;
-				\`\`\`
-
-				### Other Stories
-
-				- Small (example-button--small)
-				- With A 11 Y Violation (example-button--with-a-11-y-violation)
-
-				## Props
-
-				\`\`\`
-				export type Props = {
-				  /**
-				    Is this the principal call to action on the page?
-				  */
-				  primary?: boolean = false;
-				  /**
-				    What background color to use
-				  */
-				  backgroundColor?: string;
-				  /**
-				    How large should the button be?
-				  */
-				  size?: 'small' | 'medium' | 'large' = 'medium';
-				  /**
-				    Button contents
-				  */
-				  label: string;
-				  /**
-				    Optional click handler
-				  */
-				  onClick?: () => void;
-				}
-				\`\`\`
-
-				## Docs
-
-				### Additional Information
-
-				import { Meta, Canvas } from '@storybook/addon-docs/blocks';
-				import * as ButtonStories from './Button.stories';
-
-				<Meta of={ButtonStories} name="Additional Information" />
-
-				It is critical when using the Button component, that the string passed to the \`label\` prop uses the 🍌-emoji instead of spaces.
-
-				Here is the button:
-
-				<Canvas of={ButtonStories.Primary} />",
-				      "type": "text",
-				    },
-				  ],
-				}
-			`);
+			if (hasRemoteSource) {
+				expect(response.result).toMatchObject({
+					isError: true,
+					content: [
+						{
+							type: 'text',
+							text: expect.stringContaining('storybookId is required'),
+						},
+					],
+				});
+				return;
+			}
+
+			expect(response.result).toMatchObject({
+				content: [
+					{
+						type: 'text',
+						text: expect.stringContaining('ID: example-button'),
+					},
+				],
+			});
+			expect(response.result).not.toHaveProperty('isError');
 		});
 	});
 

apps/internal-storybook/tests/mcp-endpoint.e2e.test.ts

@@ -855,7 +855,7 @@ describe('MCP Endpoint E2E Tests', () => {
 			expect(result1.result).toBeDefined();
 			expect(result1.result.content).toBeDefined();
 			expect(result1.result.content.length).toBeGreaterThan(0);
-			
+
 			expect(result1.result.content[0].text).toContain('example-button--primary');
 			expect(result1.result.content[0].text).toContain('Passing Stories');