Skip to content

Add E2E code coverage #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kasperpeulen wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add E2E code coverage #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5ee9f8e
feat: add E2E code coverage via NODE_V8_COVERAGE
kasperpeulen Feb 13, 2026
dcc11c4
chore: update Storybook to 10.3.0-alpha.5
kasperpeulen Feb 13, 2026
c3e5b1d
fix: drop --all from c8 report to avoid conflicting with unit test co…
kasperpeulen Feb 13, 2026
ee89f3f
Revert "fix: drop --all from c8 report to avoid conflicting with unit…
kasperpeulen Feb 13, 2026
00b5373
fix: scope e2e coverage to src files matching vitest include pattern
kasperpeulen Feb 13, 2026
2eadcb9
fix: use monocart for e2e coverage to align line counts with vitest
kasperpeulen Feb 13, 2026
2e7b48a
Merge branch 'main' into kasper/e2e-coverage
JReinhold Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,17 @@ jobs:
- name: Run tests with coverage
run: pnpm turbo run test:ci

- name: Report E2E coverage
run: pnpm test:ci:report-e2e-coverage

- name: Upload coverage to Codecov
uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 # v5.5.1
with:
use_oidc: true
fail_ci_if_error: true
files: |
coverage/lcov.info
e2e-coverage-report/lcov.info

- name: Upload test results to Codecov
uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ build-storybook.log
.DS_Store
.env
coverage/
e2e-coverage/
e2e-coverage-report/
test-report.junit.xml
# Turborepo
.turbo
Expand Down
115 changes: 64 additions & 51 deletions apps/internal-storybook/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

129 changes: 80 additions & 49 deletions eval/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"release": "turbo run build && pnpm changeset publish",
"storybook": "turbo watch storybook --filter=@storybook/mcp-internal-storybook",
"test": "vitest",
"test:ci": "vitest run --coverage --reporter=default --reporter=github-actions --reporter=junit --outputFile=test-report.junit.xml",
"test:ci": "NODE_V8_COVERAGE=./e2e-coverage vitest run --coverage --reporter=default --reporter=github-actions --reporter=junit --outputFile=test-report.junit.xml",
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NODE_V8_COVERAGE=./e2e-coverage is a relative path, but the E2E tests spawn Storybook with cwd: STORYBOOK_DIR (apps/internal-storybook). That means the Storybook process will write V8 coverage into apps/internal-storybook/e2e-coverage, while the later c8 report --temp-directory ./e2e-coverage step reads from the repo root. This can result in missing/empty E2E coverage (or a failing c8 report). Consider using an absolute path for NODE_V8_COVERAGE (so it’s independent of child process CWD) or explicitly overriding NODE_V8_COVERAGE in the Storybook spawn env to point at the root coverage directory.

Suggested change
"test:ci": "NODE_V8_COVERAGE=./e2e-coverage vitest run --coverage --reporter=default --reporter=github-actions --reporter=junit --outputFile=test-report.junit.xml",
"test:ci": "NODE_V8_COVERAGE=\"$PWD/e2e-coverage\" vitest run --coverage --reporter=default --reporter=github-actions --reporter=junit --outputFile=test-report.junit.xml",

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

@kasperpeulen kasperpeulen Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relative path works because the Storybook process ends up running from the repo root (turbo resets CWD). Verified locally — all V8 coverage files land in ./e2e-coverage/ at the repo root, none in apps/internal-storybook/e2e-coverage/.

Copy link
Copy Markdown
Member

@AriPerkkio AriPerkkio Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NODE_v8_COVERAGE can be replaced with vitest --coverage.trackProcessAndWorker in future:

"test:ci:report-e2e-coverage": "c8 report --experimental-monocart --temp-directory ./e2e-coverage -r lcov -o ./e2e-coverage-report && node scripts/filter-lcov.js ./e2e-coverage-report/lcov.info '/src/.+\\.tsx?$'",
"test:run": "vitest run",
"turbo": "turbo",
"turbo:test": "turbo run test",
Expand All @@ -41,6 +42,8 @@
"@storybook/mcp": "workspace:*",
"@types/node": "20.19.0",
"@vitest/coverage-v8": "4.0.6",
"c8": "^10.1.3",
"monocart-coverage-reports": "^2.12.9",
"oxfmt": "^0.27.0",
"oxlint": "^1.25.0",
"oxlint-tsgolint": "^0.4.0",
Expand Down
1 change: 1 addition & 0 deletions packages/addon-mcp/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.map
12 changes: 6 additions & 6 deletions packages/addon-mcp/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/mcp/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.map
Loading
Loading