Skip to content

chore: pin Storybook ADE canary#232

Draft
kasperpeulen wants to merge 20 commits into
mainfrom
kasper/ade-canary-smoke
Draft

chore: pin Storybook ADE canary#232
kasperpeulen wants to merge 20 commits into
mainfrom
kasper/ade-canary-smoke

Conversation

@kasperpeulen

@kasperpeulen kasperpeulen commented May 21, 2026

Copy link
Copy Markdown
Member

What

Pins the MCP repo default Storybook catalog entries used by apps/internal-storybook to the Storybook ADE runtime registry canary:

  • storybook@0.0.0-pr-34863-sha-27c62c27
  • @storybook/react-vite@0.0.0-pr-34863-sha-27c62c27
  • @storybook/addon-a11y@0.0.0-pr-34863-sha-27c62c27
  • @storybook/addon-docs@0.0.0-pr-34863-sha-27c62c27
  • @storybook/addon-themes@0.0.0-pr-34863-sha-27c62c27
  • @storybook/addon-vitest@0.0.0-pr-34863-sha-27c62c27

This is a temporary verification branch stacked on #226 so the canary-backed internal Storybook fixture can be run directly.

Validation

  • npm view storybook@0.0.0-pr-34863-sha-27c62c27 version --registry=https://registry.npmjs.org/
  • pnpm install
    • local install still reports ERR_PNPM_MISSING_HOISTED_LOCATIONS for ajv-formats, matching the pre-existing local node_modules issue, but packages link and commands below pass
  • node version check confirmed apps/internal-storybook resolves Storybook packages to 0.0.0-pr-34863-sha-27c62c27
  • pnpm --filter @storybook/mcp-proxy test
  • pnpm --filter @storybook/mcp-internal-storybook storybook
  • inspected ~/.storybook/instances/*.json and confirmed cwd, pid, url, port, canary storybookVersion, and mcp.status ready with /mcp endpoint
  • curl tools/list against http://localhost:6006/mcp
  • pnpm --filter @storybook/mcp-proxy build
  • MCP SDK stdio smoke against packages/mcp-proxy/dist/bin.js calling list-all-documentation with apps/internal-storybook cwd returned isError false
  • SIGINT cleanup removed the registry record

Update

CI initially failed in apps/internal-storybook/tests/check-deps.e2e.test.ts because this verification branch intentionally pins Storybook packages to a PR canary instead of the latest next dist-tag (10.5.0-alpha.0). This branch now allows Storybook PR canary versions matching 0.0.0-pr-<pr>-sha-<sha> for that freshness check so the temporary canary QA PR can go green.

The branch now uses the current Storybook PR-head canary, 0.0.0-pr-34863-sha-27c62c27.

@changeset-bot

changeset-bot Bot commented May 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a471439

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented May 21, 2026

Copy link
Copy Markdown
npx https://pkg.pr.new/storybookjs/mcp/@storybook/addon-mcp@232
npx https://pkg.pr.new/storybookjs/mcp/@storybook/mcp@232
npx https://pkg.pr.new/storybookjs/mcp/@storybook/mcp-proxy@232

commit: a471439

@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 78.69kB (-49.09%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@storybook/mcp-esm* 48.48kB -2.17kB (-4.29%) ⬇️
@storybook/addon-mcp-esm* 5.05kB -77.75kB (-93.9%) ⬇️
@storybook/mcp-proxy-esm 28.1kB 1.23kB (4.56%) ⬆️

ℹ️ *Bundle size includes cached data from a previous commit

Affected Assets, Files, and Routes:

view changes for bundle: @storybook/mcp-proxy-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
src-CoOMfnQg.js (New) 25.0kB 25.0kB 100.0% 🚀
src-Diep_yiq.js (Deleted) -23.77kB 0 bytes -100.0% 🗑️

Files in src-CoOMfnQg.js:

  • ./src/tools/intercepts.ts → Total Size: 4.16kB

  • ./src/tools/proxy-tool.ts → Total Size: 1.73kB

view changes for bundle: @storybook/mcp-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.js -1.69kB 31.95kB -5.03%
index.d.ts -478 bytes 15.32kB -3.03%
view changes for bundle: @storybook/addon-mcp-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
preview-*.js (New) 5.05kB 5.05kB 100.0% 🚀
preset.js (Deleted) -82.8kB 0 bytes -100.0% 🗑️

@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.60465% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.24%. Comparing base (a2ab074) to head (a471439).
⚠️ Report is 86 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
packages/addon-mcp/src/tools/display-review.ts 86.66% 1 Missing and 3 partials ⚠️
packages/addon-mcp/src/auth/composition-auth.ts 78.57% 1 Missing and 2 partials ⚠️
packages/addon-mcp/src/mcp-handler.ts 50.00% 1 Missing and 1 partial ⚠️
...-mcp/src/instructions/build-server-instructions.ts 75.00% 0 Missing and 1 partial ⚠️
packages/addon-mcp/src/types.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   75.99%   78.24%   +2.24%     
==========================================
  Files          52       57       +5     
  Lines        1412     1558     +146     
  Branches      391      432      +41     
==========================================
+ Hits         1073     1219     +146     
+ Misses        205      203       -2     
- Partials      134      136       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feat/mcp-proxy-setup to main May 21, 2026 11:53
@netlify

netlify Bot commented Jun 1, 2026

Copy link
Copy Markdown

Deploy Preview for storybook-mcp-self-host-example canceled.

Name Link
🔨 Latest commit a471439
🔍 Latest deploy log https://app.netlify.com/projects/storybook-mcp-self-host-example/deploys/6a1d8b909b059300089b1a2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants