You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
View the top 1 failed test(s) by shortest run time
packages/mcp-proxy/src/tools/upstream-coverage.test.ts > proxy upstream tool coverage > registers every upstream tool that is not explicitly excluded
Stack Traces | 0.0261s run time
AssertionError: Upstream tool(s) ["get-stories-by-component"] are not registered in the proxy. Add them in src/tools/index.ts (and duplicate their schema in shared.ts), or add them to INTENTIONALLY_NOT_PROXIED with a reason.: expected [ 'get-stories-by-component' ] to deeply equal []
- Expected
+ Received
- []
+ [
+ "get-stories-by-component",
+ ]
❯ src/tools/upstream-coverage.test.ts:62:5
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds a new Vitest suite in mcp-proxy to ensure the proxy’s hand-maintained tool registry stays synchronized with tool names exported by the upstream @storybook/mcp and @storybook/addon-mcp packages.
Changes:
Added upstream-coverage.test.ts to assert the proxy registers all upstream tools (with explicit allow/deny lists).
Added workspace devDependencies on @storybook/mcp and @storybook/addon-mcp for mcp-proxy tests.
Added a root tsconfig.json path alias to import addon tool-name constants from source.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
File
Description
tsconfig.json
Adds a TS path alias for @storybook/addon-mcp/tool-names so tests can import tool name constants.
/** Pull every exported `*_TOOL_NAME` string constant out of a module namespace. */
function toolNamesOf(mod: Record<string, unknown>): string[] {
return Object.entries(mod)
.filter(([key, value]) => key.endsWith('TOOL_NAME') && typeof value === 'string')
.map(([, value]) => value as string);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds upstream-coverage.test.ts, which guards that the proxy's hand-maintained tool catalog stays in sync with the upstream Storybook MCP packages.