Fix scriptsBinPath is not a link #268
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, files in the .bin directory are not links, such as in projects generated by rushjs.
ndelangen
requested changes
Jan 16, 2023
| const scriptsPath = join(resolvedBinPath, '..', '..'); | ||
| return scriptsPath; | ||
| } else if (scriptsBinPathStat.isFile() === true) { | ||
| const scriptsPath = join(cwd, '/node_modules/react-scripts'); |
Member
There was a problem hiding this comment.
Looks like this might need to be changed to use path.join for cross-platform-compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, files in the .bin directory are not links, such as in projects generated by rushjs.