Conversation
✅ Deploy Preview for sb-react-inspector ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
817fa53 to
9219668
Compare
a31ae30 to
aa9e87e
Compare
BREAKING CHANGE: React 16 and 17 are no longer supported.
3181400 to
023ecef
Compare
023ecef to
5e6a391
Compare
|
Still needing a |
|
@Sidnioulz It should be disabled now. |
Thank you! |
…ter function name preservation
…update chromatic version in package.json
…rybook, ESLint, TypeScript, and Vitest versions
…y are no longer needed
…karma configuration
…types for better control
…ved job management
…flow to use auto shipit for releases
|
@JReinhold have we setup I suspect if merged, the release version won't be bumped correctly, can you check/confirm/ give advice please? |
|
@Sidnioulz I think the upgrades are all concluded, and the npm publishing is confirmed to work. |
IIRC auto bumps versions based on PR labels only. If the job runs from a PR hook, it should bump. But if it doesn't, we should get a NPM publish conflict version anyway. |
|
Thanks so much for finishing this tidy up @ndelangen! |
|
@ndelangen alas, the release job got skipped: https://github.com/storybookjs/react-inspector/actions/runs/17417753185/job/49449864005. We made it release on I also notice Dependabot is paused, also lacking privs to resume it. Once the NPM release is done, I can take care of cleaning up all the stale issues and communicating to the Remix router people. |
|
Looks like changing the default branch did cause a release to happen, but pushing the git tags failed. https://www.npmjs.com/package/react-inspector?activeTab=versions |
|
I see 8.0 though! |
|
Yeah, it seemed to have skipped 7.0.0 completely. I suspect I've setup |
That was my fault. Kinda the reason why I'm not too comfortable with auto: you either don't set PR labels and manually update version, or the other way around. I updated the version. You set the label. We bumped twice. But that's ok, this is a process error that results in the wrong version being applied. Only actually an issue if we release on the same version (would error out, so no harm done) or a minor instead of major (we can recover those manually and unpublish, though not great DX if we catch it late). I'm more concerned with the CI triggers trying to re-publish on |
jestwithvitestwebpackwithviteautowith labelstype=module@xyc it'd be lovely if you could please disable your Netlify app on this repo. It's giving out errors and we can't disable it from our side. Thanks!
📦 Published PR as canary version:
7.0.1--canary.190.17416995031.0✨ Test out this PR locally via:
npm install react-inspector@7.0.1--canary.190.17416995031.0 # or yarn add react-inspector@7.0.1--canary.190.17416995031.0