Skip to content

fix: Allow React 19 as peer dependency#190

Merged
Sidnioulz merged 30 commits intomasterfrom
deps/react-19
Sep 2, 2025
Merged

fix: Allow React 19 as peer dependency#190
Sidnioulz merged 30 commits intomasterfrom
deps/react-19

Conversation

@Sidnioulz
Copy link
Copy Markdown
Member

@Sidnioulz Sidnioulz commented Aug 12, 2025

  • Port to React 18/19 syntax
  • Add Storybook 9 to peer dependencies
  • Port local package to Storybook 9
  • Update CI runners and jobs
  • Audit and update all tooling
  • Replace jest with vitest
  • Replace webpack with vite
  • Enable auto with labels
  • Migrate package to type=module

@xyc it'd be lovely if you could please disable your Netlify app on this repo. It's giving out errors and we can't disable it from our side. Thanks!

📦 Published PR as canary version: 7.0.1--canary.190.17416995031.0

✨ Test out this PR locally via:

npm install react-inspector@7.0.1--canary.190.17416995031.0
# or 
yarn add react-inspector@7.0.1--canary.190.17416995031.0

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 12, 2025

Deploy Preview for sb-react-inspector ready!

Name Link
🔨 Latest commit 260b804
🔍 Latest deploy log https://app.netlify.com/projects/sb-react-inspector/deploys/68a59109f3132c0008aca1ca
😎 Deploy Preview https://deploy-preview-190--sb-react-inspector.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Sidnioulz Sidnioulz mentioned this pull request Aug 20, 2025
@Sidnioulz Sidnioulz force-pushed the deps/react-19 branch 3 times, most recently from 3181400 to 023ecef Compare August 20, 2025 09:53
@Sidnioulz Sidnioulz requested a review from ndelangen August 20, 2025 10:11
@Sidnioulz
Copy link
Copy Markdown
Member Author

Still needing a NPM_TOKEN secret to produce the canary.

@xyc
Copy link
Copy Markdown
Contributor

xyc commented Aug 26, 2025

@Sidnioulz It should be disabled now.

@Sidnioulz
Copy link
Copy Markdown
Member Author

@Sidnioulz It should be disabled now.

Thank you!

@Sidnioulz Sidnioulz assigned Sidnioulz and ndelangen and unassigned Sidnioulz Sep 1, 2025
@ndelangen ndelangen added the major Increment the major version when merged label Sep 2, 2025
@ndelangen
Copy link
Copy Markdown
Member

@JReinhold have we setup auto correctly?

I suspect if merged, the release version won't be bumped correctly, can you check/confirm/ give advice please?

@ndelangen
Copy link
Copy Markdown
Member

@Sidnioulz I think the upgrades are all concluded, and the npm publishing is confirmed to work.

@Sidnioulz
Copy link
Copy Markdown
Member Author

@JReinhold have we setup auto correctly?

I suspect if merged, the release version won't be bumped correctly, can you check/confirm/ give advice please?

IIRC auto bumps versions based on PR labels only. If the job runs from a PR hook, it should bump. But if it doesn't, we should get a NPM publish conflict version anyway.

@Sidnioulz
Copy link
Copy Markdown
Member Author

Thanks so much for finishing this tidy up @ndelangen!

@Sidnioulz Sidnioulz merged commit 46b54f5 into master Sep 2, 2025
2 checks passed
@Sidnioulz
Copy link
Copy Markdown
Member Author

@ndelangen alas, the release job got skipped: https://github.com/storybookjs/react-inspector/actions/runs/17417753185/job/49449864005.

We made it release on main (source). But this repo is so old it's still on master. I don't have privileges to switch default branches so I'm gonna have to delegate that to you.

I also notice Dependabot is paused, also lacking privs to resume it.

Once the NPM release is done, I can take care of cleaning up all the stale issues and communicating to the Remix router people.

@ndelangen
Copy link
Copy Markdown
Member

Looks like changing the default branch did cause a release to happen, but pushing the git tags failed.

https://www.npmjs.com/package/react-inspector?activeTab=versions

@Sidnioulz
Copy link
Copy Markdown
Member Author

This was referenced Sep 3, 2025
@ndelangen
Copy link
Copy Markdown
Member

Yeah, it seemed to have skipped 7.0.0 completely.

I suspect I've setup auto incorrectly. @JReinhold can you please tell me if that's the case?

@Sidnioulz
Copy link
Copy Markdown
Member Author

Yeah, it seemed to have skipped 7.0.0 completely.

I suspect I've setup auto incorrectly. @JReinhold can you please tell me if that's the case?

That was my fault. Kinda the reason why I'm not too comfortable with auto: you either don't set PR labels and manually update version, or the other way around.

I updated the version. You set the label. We bumped twice.

But that's ok, this is a process error that results in the wrong version being applied. Only actually an issue if we release on the same version (would error out, so no harm done) or a minor instead of major (we can recover those manually and unpublish, though not great DX if we catch it late).

I'm more concerned with the CI triggers trying to re-publish on main after the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major Increment the major version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants