Skip to content

chore: add missing dependencies #31309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Apr 29, 2025

Adds a few missing dependencies which were previously picked up thanks to sibling monorepo packages having the same dependency.

cc @webpro

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Basically ensure the build still succeeds.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

Greptile Summary

Updates package.json files across multiple Storybook packages to explicitly declare dependencies that were previously being implicitly inherited from sibling packages in the monorepo.

  • Added @types/estree to svelte-vite package for ESTree AST type definitions
  • Added @babel/core to both create-react-app preset and react renderer packages
  • Added expect-type v1.1.0 to vue3 and react renderer packages
  • Added browser-assert and expect-type to core package
  • Added @babel/types to vitest addon package

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

Adds a few missing dependencies which were previously picked up thanks
to sibling monorepo packages having the same dependency.
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@webpro
Copy link
Contributor

webpro commented Apr 29, 2025

Maybe what we could consider and investigate is remove more dependencies from code/package.json to make packages more self-contained. Then Knip can detect them properly as well. pnpm would help here too.

Copy link

nx-cloud bot commented Apr 29, 2025

View your CI Pipeline Execution ↗ for commit 3be46b4.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 43s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-02 10:07:41 UTC

@43081j
Copy link
Contributor Author

43081j commented Apr 29, 2025

knip is already detecting this, isn't it? 👀

I thought that's how we got the warnings before. it detected that the sub-packages didn't have the right dependencies, even though code/ did

maybe I'm mistaken :D

@webpro
Copy link
Contributor

webpro commented Apr 29, 2025

lol yes I forgot about strict mode, and didn't use that in my latest PR here unfortunately. Comes with more strictness, isolated packages should probably be separate flag. So many projects, so many setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants