-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
chore: add missing dependencies #31309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
Adds a few missing dependencies which were previously picked up thanks to sibling monorepo packages having the same dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Maybe what we could consider and investigate is remove more dependencies from |
View your CI Pipeline Execution ↗ for commit 3be46b4.
☁️ Nx Cloud last updated this comment at |
knip is already detecting this, isn't it? 👀 I thought that's how we got the warnings before. it detected that the sub-packages didn't have the right dependencies, even though maybe I'm mistaken :D |
lol yes I forgot about strict mode, and didn't use that in my latest PR here unfortunately. Comes with more strictness, isolated packages should probably be separate flag. So many projects, so many setups. |
Adds a few missing dependencies which were previously picked up thanks to sibling monorepo packages having the same dependency.
cc @webpro
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Basically ensure the build still succeeds.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.Greptile Summary
Updates package.json files across multiple Storybook packages to explicitly declare dependencies that were previously being implicitly inherited from sibling packages in the monorepo.
@types/estree
tosvelte-vite
package for ESTree AST type definitions@babel/core
to bothcreate-react-app
preset andreact
renderer packagesexpect-type
v1.1.0 tovue3
andreact
renderer packagesbrowser-assert
andexpect-type
tocore
package@babel/types
tovitest
addon package💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!