Skip to content

fix: incorrect package json handling #34515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lino-levan wants to merge 1 commit into
base: next
Choose a base branch
from
+2 −5
Open

fix: incorrect package json handling #34515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions code/core/src/common/utils/get-storybook-refs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { logger } from 'storybook/internal/node-logger';
import type { Options, Ref } from 'storybook/internal/types';

import * as pkg from 'empathic/package';
import * as resolve from 'empathic/resolve';

import { getProjectRoot } from './paths.ts';

Expand All @@ -23,7 +22,7 @@ export const getAutoRefs = async (options: Options): Promise<Record<string, Ref>
const list = await Promise.all(
deps.map(async (d) => {
try {
const l = resolve.from(directory, join(d, 'package.json'));
const l = join(directory, 'node_modules', d, 'package.json');

const { storybook, name, version } =
JSON.parse(await readFile(l, { encoding: 'utf8' })) || {};
Expand All @@ -32,9 +31,7 @@ export const getAutoRefs = async (options: Options): Promise<Record<string, Ref>
return { id: name, ...storybook, version };
}
} catch (error) {
if ((error as any).code === 'ERR_PACKAGE_PATH_NOT_EXPORTED') {
// silent warning because user can't do anything about it
// "package.json" is not part of the package's "exports" field in its package.json
if ((error as NodeJS.ErrnoException).code === 'ENOENT') {
return undefined;
}
logger.warn(`unable to find package.json for ${d}`);
Expand Down
Loading