Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions code/lib/create-storybook/src/services/ProjectTypeService.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,28 @@ describe('ProjectTypeService', () => {
expect(result).toBe(ProjectType.REACT_NATIVE);
});

it('detects REACT_NATIVE via peerDependencies', async () => {
(pm as any).primaryPackageJson.packageJson = {
peerDependencies: { react: '^18.0.0', 'react-native': '^0.76.0' },
};
const service = new ProjectTypeService(pm);
// @ts-expect-error private method spy
vi.spyOn(service, 'isNxProject').mockReturnValue(false);
const result = await service.autoDetectProjectType({ html: false } as CommandOptions);
expect(result).toBe(ProjectType.REACT_NATIVE);
});

it('detects REACT_NATIVE via peerDependencies react-native-scripts', async () => {
(pm as any).primaryPackageJson.packageJson = {
peerDependencies: { react: '^18.0.0', 'react-native-scripts': '^5.0.0' },
};
const service = new ProjectTypeService(pm);
// @ts-expect-error private method spy
vi.spyOn(service, 'isNxProject').mockReturnValue(false);
const result = await service.autoDetectProjectType({ html: false } as CommandOptions);
expect(result).toBe(ProjectType.REACT_NATIVE);
});

it('detects NUXT via nuxt', async () => {
(pm as any).primaryPackageJson.packageJson = {
dependencies: { nuxt: '^3.0.0' },
Expand All @@ -199,6 +221,53 @@ describe('ProjectTypeService', () => {
const result = await service.autoDetectProjectType({ html: false } as CommandOptions);
expect(result).toBe(ProjectType.NUXT);
});

it('detects REACT via peerDependencies', async () => {
(pm as any).primaryPackageJson.packageJson = {
peerDependencies: { react: '^18.0.0' },
};
const service = new ProjectTypeService(pm);
// @ts-expect-error private method spy
vi.spyOn(service, 'isNxProject').mockReturnValue(false);
const result = await service.autoDetectProjectType({ html: false } as CommandOptions);
expect(result).toBe(ProjectType.REACT);
});

it('detects REACT via devDependencies', async () => {
(pm as any).primaryPackageJson.packageJson = {
devDependencies: { react: '^18.0.0' },
};
const service = new ProjectTypeService(pm);
// @ts-expect-error private method spy
vi.spyOn(service, 'isNxProject').mockReturnValue(false);
const result = await service.autoDetectProjectType({ html: false } as CommandOptions);
expect(result).toBe(ProjectType.REACT);
});

it('prefers REACT_NATIVE over REACT when markers are split across dependency sections', async () => {
(pm as any).primaryPackageJson.packageJson = {
dependencies: { 'react-native': '^0.76.0' },
peerDependencies: { react: '^18.0.0' },
};
const service = new ProjectTypeService(pm);
// @ts-expect-error private method spy
vi.spyOn(service, 'isNxProject').mockReturnValue(false);
const result = await service.autoDetectProjectType({ html: false } as CommandOptions);
expect(result).toBe(ProjectType.REACT_NATIVE);
});

it('does not detect REACT from react-dom alone', async () => {
(pm as any).primaryPackageJson.packageJson = {
peerDependencies: { 'react-dom': '^18.0.0' },
};
const service = new ProjectTypeService(pm);
// @ts-expect-error private method spy
vi.spyOn(service, 'isNxProject').mockReturnValue(false);

await expect(
service.autoDetectProjectType({ html: false } as CommandOptions)
).rejects.toThrowError('Storybook failed to detect your project type');
});
});

describe('validateProvidedType', () => {
Expand Down
10 changes: 6 additions & 4 deletions code/lib/create-storybook/src/services/ProjectTypeService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,9 @@ export class ProjectTypeService {
{
preset: ProjectType.REACT_NATIVE,
dependencies: ['react-native', 'react-native-scripts'],
matcherFunction: ({ dependencies }) => {
return dependencies?.some(Boolean) ?? false;
peerDependencies: ['react-native', 'react-native-scripts'],
matcherFunction: ({ dependencies, peerDependencies }) => {
return (dependencies?.some(Boolean) || peerDependencies?.some(Boolean)) ?? false;
},
},
{
Expand Down Expand Up @@ -139,8 +140,9 @@ export class ProjectTypeService {
{
preset: ProjectType.REACT,
dependencies: ['react'],
matcherFunction: ({ dependencies }) => {
return dependencies?.every(Boolean) ?? true;
peerDependencies: ['react'],
matcherFunction: ({ dependencies, peerDependencies }) => {
return (dependencies?.some(Boolean) || peerDependencies?.some(Boolean)) ?? false;
},
},
];
Expand Down
Loading