fix(builder-vite): avoid duplicate publicDir copies with staticDirs#34524
Open
harshit-d3v wants to merge 1 commit intostorybookjs:nextfrom
Open
fix(builder-vite): avoid duplicate publicDir copies with staticDirs#34524harshit-d3v wants to merge 1 commit intostorybookjs:nextfrom
harshit-d3v wants to merge 1 commit intostorybookjs:nextfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThese changes add logic to Storybook's Vite builder to conditionally disable Vite's Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicDircopy when StorybookstaticDirsalready includes the same directorypublic/index.jsoncan overwrite Storybook's generatedstorybook-static/index.jsonpublicDirvalues, plus build vs development behaviorCloses #24627.
Testing
yarn vitest run code/builders/builder-vite/src/vite-config.test.tsSummary by CodeRabbit
Tests
Bug Fixes