chore: Remove jest-process-manager dependency by implementing server …#598
Open
ysknsid25 wants to merge 1 commit into
Open
chore: Remove jest-process-manager dependency by implementing server …#598ysknsid25 wants to merge 1 commit into
ysknsid25 wants to merge 1 commit into
Conversation
…management inline Signed-off-by: ysknsid25 <kengo071225@gmail.com>
aa27206 to
75efba6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
jest-process-manageris now a public archive and can no longer be updated. Its transitive dependencyaxioscontains a known vulnerability (CVE-2026-40175). Specifically,jest-process-managerdepends onwait-on@^7.0.0, which in turn depends on a vulnerable version ofaxios. Sincejest-process-manageris archived, there is no way to get a fix, meaning the vulnerability will remain indefinitely. Depending on a publicly archived package is also generally inappropriate.As an alternative,
jest-dev-server— the package thatjest-process-managerwas originally forked from — is also archived and cannot be used as a replacement.This PR removes the dependency entirely by reimplementing the
setup/teardownfunctionality inline using Node.js built-inchild_processand the existingwait-ondevDependency. The API signature remains fully compatible with the previous behavior.Checklist for Contributors
Manual Testing Steps
A minimal reproduction environment is available in the
test/directory of thetest/server-options-reprobranch.Setup
Run
What to verify
serverOptionsstartssrc/mock-server.js(port 3001) automatically before tests runMock server running on port 3001Button/PrimaryandButton/Secondarystories passsrc/mock-server.jsprocess is terminated after tests completelsof -ti :3001returns nothing after the run"Jest did not exit one second after the test run"warning)Expected output
Documentation
Checklist for Maintainers
Make sure this PR contains one of the labels below:
Available labels
skip-release: Skip any releases, e.g., documentation only changes, CI config etc.patch: Upgrade patch version (e.g. 0.0.x)minor: Upgrade patch version (e.g. 0.x.0)major: Upgrade patch version (e.g. x.0.0)