feat: implemented SPG registration with fee payer support#373
Open
0xObsidian wants to merge 1 commit intostoryprotocol:mainfrom
Open
feat: implemented SPG registration with fee payer support#3730xObsidian wants to merge 1 commit intostoryprotocol:mainfrom
0xObsidian wants to merge 1 commit intostoryprotocol:mainfrom
Conversation
0xObsidian
requested review from
LeoHChen,
Spablob and
kingster-will
as code owners
Author
|
Hi @kingster-will |
0xObsidian
force-pushed
the
0xObsidian/SPG-registration-with-fee-payer-support
branch
from
b5342ac to
cd75232
Compare
This PR introduces changes that allows the fee to be paid by the intended user while SPG performs the registration. Description: ------------ - Added registerWithFeePayer for SPG to register IPs with user-paid fees - Added SPG address to storage with restricted setter - Added access control to make sure only SPG can use the new function - Added comprehensive test suite for SPG registration flows Testing the introduced `feat`: ------------------------------ Fetch this PR branch and from the root directory, run: ``` forge test --match-test "test_SPGRegistrationWithFeePayer|test_revert_NonSPGCannotRegisterWithFeePayer|test_revert_SPGCannotRegisterWhenFeeActive" -vv ```
0xObsidian
force-pushed
the
0xObsidian/SPG-registration-with-fee-payer-support
branch
from
cd75232 to
a866395
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces changes that allows the fee to be paid by the intended user while SPG performs the registration:
Test Plan
Fetch this PR branch and from the root directory, run:
Related Issue
This PR addresses ticket #305