Fix JSON formatting issue and typos #385
Open
Himess wants to merge 3 commits intostoryprotocol:mainfrom
Open
Conversation
Himess
requested review from
LeoHChen,
Spablob and
kingster-will
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Description
This PR resolves a JSON formatting issue and addresses multiple typos across the codebase. Below is a detailed breakdown of the changes made:
1. GroupNFT.sol
Issue:
The 'description' field in the 'tokenURI' function contained incorrect JSON formatting, which could lead to invalid JSON.
'"description": IPAsset Group",' to '"description": "IPAsset Group",'
2. IPAccountImpl.sol
Issues:
1-The word 'bethe' was a typo in a comment.
2-A missing word ('for') in a comment made it unclear.
'bethe' to 'be the'
'/// @dev Updates the IP Account's state all execute transactions.' to '/// @dev Updates the IP Account's state for all executed transactions.'
3. StorageLayoutCheck.s.sol
Issue:
'string.concat' was unnecessarily used for a single string in the 'inputBuilder.'
'inputBuilder[i++] = string.concat("@openzeppelin/upgrades-core");' to 'inputBuilder[i++] = "@openzeppelin/upgrades-core";'
Why These Changes Were Made
-To ensure valid JSON formatting for GroupNFT.
-To fix typos and improve clarity in comments for better readability.
-To remove unnecessary code and improve efficiency in StorageLayoutCheck.