fix(test): add test case to total license token limit hook#229
Merged
sebsadface merged 1 commit intostoryprotocol:mainfrom Jun 24, 2025
Merged
fix(test): add test case to total license token limit hook#229sebsadface merged 1 commit intostoryprotocol:mainfrom
sebsadface merged 1 commit intostoryprotocol:mainfrom
Conversation
romain-mg
requested review from
LeoHChen,
Spablob,
kingster-will and
sebsadface
as code owners
romain-mg
changed the title
sebsadface
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new test function to improve test coverage for the totalLicenseTokenLimit hook, ensuring its correct behavior during derivative registration.
It also includes a couple of linter styling changes
Test added
test_TotalLicenseTokenLimitHook_beforeRegisterDerivative_incrementTotalLicenseTokenSupply()
Purpose: Validates that the beforeRegisterDerivative() hook correctly increments the total license token supply when a new derivative is registered.
Coverage improvement
Before:
After: