Fix: SPGNFT metadata hash setter#233
Merged
romain-mg merged 6 commits intostoryprotocol:mainfrom Jul 15, 2025
Merged
Conversation
e77bc78 to
b342ee1
Compare
b342ee1 to
06763ea
Compare
06763ea to
e633964
Compare
sebsadface
reviewed
Jun 29, 2025
sebsadface
reviewed
Jun 30, 2025
8df29f0 to
5e724b8
Compare
5e724b8 to
a5827b9
Compare
sebsadface
reviewed
Jul 14, 2025
sebsadface
reviewed
Jul 14, 2025
sebsadface
reviewed
Jul 14, 2025
sebsadface
reviewed
Jul 14, 2025
sebsadface
reviewed
Jul 14, 2025
6a47545 to
93a3517
Compare
sebsadface
reviewed
Jul 15, 2025
sebsadface
reviewed
Jul 15, 2025
93a3517 to
a07f11a
Compare
a07f11a to
e10bc9b
Compare
e10bc9b to
e56346e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds functionality to allow NFT owners to update the metadata (both URI and hash) of their tokens in SPGNFT collections.
Changes Made
Core Functionality
setTokenURI(uint256 tokenId, string memory tokenUri, bytes32 nftMetadataHash)external function in SPGNFT.sol -> allows token owners to update both metadata URI and metadata hash for their tokensInterface Updates
setTokenURI(uint256 tokenId, string memory tokenUri, bytes32 nftMetadataHash)function declaration in ISPGNFT.solsetTokenURI(uint256 tokenId, string memory tokenUri)function as deprecatedError Handling
Testing
Related Issues
Closes #232