feat: auto-approve erc20 token #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ken handling across multiple resources
…ing in contract calls
…er grouping logic
…IP and ERC20 handling
…est to use unified ERC20 and WIP options; enhance fee handling tests for ERC20 integration
… including derivative IP handling and license terms validation
…oken fees, enhancing fee calculation and registration workflows
…ions` for consistency in IP asset handling
…options for consistency across SDK resources
…ling, ensuring proper fee management for public and private minting
…entation for clarity on erc20 and wrapped IP token usage
bonnie57
changed the title
bonnie57
requested review from
DonFungible,
LeoHChen,
edisonz0718 and
jacob-tucker
as code owners
bonnie57
changed the title
… structures for royalty token distribution requests
…lient tests for clarity on ERC20 and WIP token usage
… registerHelper files for consistency
…ling and improve type documentation for token spending
lucas2brh
approved these changes
Nov 18, 2025
roycezhaoca
approved these changes
Nov 18, 2025
lucas2brh
approved these changes
Nov 18, 2025
…ll for WIP token registration and clean up test case for clarity
bonnie57
changed the title
lucas2brh
approved these changes
Nov 20, 2025
roycezhaoca
approved these changes
Nov 20, 2025
This was referenced Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, all functions that convert IP to WIP for minting fees handle fees only in WIP tokens. To future-proof for scenarios where minting fees can be paid with other tokens, update these functions to also handle token approvals when fees are not in WIP.
Scope