Skip to content

feat: Auto approve license tokens #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jia57b merged 4 commits into from
Nov 20, 2025
Merged

feat: Auto approve license tokens #663

jia57b merged 4 commits into from
Nov 20, 2025

Conversation

@bonnie57
Copy link
Collaborator

@bonnie57 bonnie57 commented Nov 18, 2025 •
edited
Loading

Description

  1. Add an autoApproveLicenseTokens to the following methods, and the default value is true:
  • registerIpAndMakeDerivativeWithLicenseTokens
  • mintAndRegisterIpAndMakeDerivativeWithLicenseTokens
  1. Since these two methods are called by registerDerivativeIpAsset, also add the autoApproveLicenseTokens option to registerDerivativeIpAsset.
  2. Add the integration and unit tests
  3. Remove manually approved from the integration tests

@bonnie57 bonnie57 marked this pull request as ready for review November 18, 2025 10:15
@bonnie57 bonnie57 changed the title feat: Auto approve license tokens if not approved feat: Auto approve license tokens Nov 18, 2025
@lucas2brh lucas2brh requested a review from jia57b November 20, 2025 08:54
@jia57b jia57b merged commit 0af2df9 into main Nov 20, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas2brh lucas2brh lucas2brh approved these changes

@jia57b jia57b jia57b approved these changes

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

@DonFungible DonFungible Awaiting requested review from DonFungible DonFungible is a code owner

@edisonz0718 edisonz0718 Awaiting requested review from edisonz0718 edisonz0718 is a code owner

@jacob-tucker jacob-tucker Awaiting requested review from jacob-tucker jacob-tucker is a code owner

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu AndyBoWu is a code owner

@allenchuang allenchuang Awaiting requested review from allenchuang allenchuang is a code owner

@limengformal limengformal Awaiting requested review from limengformal limengformal is a code owner

@roycezhaoca roycezhaoca Awaiting requested review from roycezhaoca

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bonnie57 @lucas2brh @jia57b @roycezhaoca