Skip to content

test: remove redundant error case in integration tests #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bonnie57 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: remove redundant error case in integration tests #679

bonnie57 wants to merge 1 commit into from

Conversation

@bonnie57
Copy link
Collaborator

@bonnie57 bonnie57 commented Jan 5, 2026

Description

  • Removed error case and edge case integration tests that primarily validate contract-level error messages
  • Streamlined test suite by removing tests for invalid inputs (unregistered IPs, invalid signatures, non-existent tokens)
  • Reduces integration test runtime while maintaining core functionality coverage

@bonnie57 bonnie57 changed the title test: remove redundant error case integration tests test: remove redundant error case in integration tests Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roycezhaoca roycezhaoca roycezhaoca approved these changes

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

@DonFungible DonFungible Awaiting requested review from DonFungible DonFungible is a code owner

@edisonz0718 edisonz0718 Awaiting requested review from edisonz0718 edisonz0718 is a code owner

@jacob-tucker jacob-tucker Awaiting requested review from jacob-tucker jacob-tucker is a code owner

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu AndyBoWu is a code owner

@allenchuang allenchuang Awaiting requested review from allenchuang allenchuang is a code owner

@limengformal limengformal Awaiting requested review from limengformal limengformal is a code owner

@lucas2brh lucas2brh Awaiting requested review from lucas2brh lucas2brh is a code owner

@yingyangxu2026 yingyangxu2026 Awaiting requested review from yingyangxu2026

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bonnie57 @roycezhaoca