feat: Add validation for inputs currency and currencyToken. #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingyangxu2026
requested review from
AndyBoWu,
DonFungible,
LeoHChen,
allenchuang,
bonnie57,
edisonz0718,
jacob-tucker,
limengformal and
lucas2brh
as code owners
yingyangxu2026
had a problem deploying
to
odyssey
GitHub Actions
Failure
lucas2brh
reviewed
Jan 16, 2026
yingyangxu2026
changed the title
bonnie57
reviewed
Jan 19, 2026
| "0x1514000000000000000000000000000000000000" as Address, // WIP | ||
| ], | ||
| } as const satisfies Record<SupportedChainIds, readonly Address[]>; | ||
|
|
Collaborator
There was a problem hiding this comment.
Could you try using a function instead object? Can you wrap the error into the function instead layout many places?
| }); | ||
|
|
||
| describe("Test groupClient.collectRoyalties", () => { | ||
| describe("TSSDK-135(Add validation for inputs currency and currencyToken.) Test groupClient.collectRoyalties", () => { |
Collaborator
There was a problem hiding this comment.
The same as the above one.
| expect(oov3Contract).to.equal(mockAddress); | ||
| }); | ||
|
|
||
| describe("TSSDK-135(Add validation for inputs currency and currencyToken.) getMinimumBond", () => { |
Collaborator
There was a problem hiding this comment.
The same as the above one.
| }); | ||
|
|
||
| describe("commercialUse", () => { | ||
| describe("TSSDK-135(Add validation for inputs currency and currencyToken.) commercialUse", () => { |
Collaborator
There was a problem hiding this comment.
Please check the similar issues.
| export const mockAddress = "0x73fcb515cee99e4991465ef586cfe2b072ebb513"; | ||
| // Use addresses that are whitelisted in `allowedCurrenciesByChain` for unit tests that exercise currency checks. | ||
| export const mockERC20 = "0xF2104833d386a2734a4eB3B8ad6FC6812F29E38E"; | ||
| export const mockAddress = "0x1514000000000000000000000000000000000000"; |
Collaborator
There was a problem hiding this comment.
You can directly get WIP from "./constants/common"
| "eslint-config-turbo": "^1.13.4", | ||
| "eslint-import-resolver-typescript": "^4.3.4", | ||
| "eslint-plugin-import": "^2.31.0", | ||
| "eslint-plugin-turbo": "^1.13.4", |
Collaborator
There was a problem hiding this comment.
Please focus on the ticket feature. We don't need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is adding validation for inputs currency and currencyToken., includes：
Aeneid: Input parameterscurrency/currencyTokenacceptsWIPorMERC20.Mainnet: Input parameterscurrency/currencyTokenacceptsWIP.WIP address:
0x1514000000000000000000000000000000000000MERC20 address:
0xF2104833d386a2734a4eB3B8ad6FC6812F29E38ETest Plan
Add unit tests for the modified APIs.