Closed
Conversation
yingyangxu2026
requested review from
LeoHChen,
allenchuang,
chao-peng-story,
jacob-tucker,
limengformal,
lucas2brh and
roycezhaoca
as code owners
lucas2brh
reviewed
Mar 2, 2026
| - **Kernel client as wallet**: Verifies that `writeContract` returns a real txHash and the SDK works correctly without a resolver. | ||
| - **Raw userOp wallet + txHashResolver**: Uses a custom wallet wrapper (whose `writeContract` returns a userOpHash) to verify end-to-end that the resolver converts the userOpHash into a real on-chain txHash. | ||
| - ZeroDev E2E tests require `BUNDLER_RPC_URL` and `WALLET_PRIVATE_KEY` in `.env`. Tests are automatically skipped when these are not configured. | ||
| * **Currency tokens**: If you pass a custom `currency` or `currencyToken`, ensure it is allowed for your chain: **Mainnet = WIP only**; **Aeneid = WIP or MERC20**. Using MERC20 on Mainnet (or an unsupported token on any chain) will now throw at runtime. |
Collaborator
There was a problem hiding this comment.
I assume this is only an explicit information that informs users the currency is not supported, and not a breaking change—i.e., users won’t need to change anything on their side. Is that correct?
lucas2brh
reviewed
Mar 2, 2026
| - ZeroDev E2E tests require `BUNDLER_RPC_URL` and `WALLET_PRIVATE_KEY` in `.env`. Tests are automatically skipped when these are not configured. | ||
| * **Currency tokens**: If you pass a custom `currency` or `currencyToken`, ensure it is allowed for your chain: **Mainnet = WIP only**; **Aeneid = WIP or MERC20**. Using MERC20 on Mainnet (or an unsupported token on any chain) will now throw at runtime. | ||
| * **AA wallets**: Optional. Add `txHashResolver` only when your wallet’s `writeContract` returns a UserOperation hash; otherwise no change. | ||
| * No other breaking changes. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * No other breaking changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.