Skip to content

fix(mcp): correct render caption dimension separator - #337

Draft
MacallanTheRoot wants to merge 1 commit into
storytold:mainfrom
MacallanTheRoot:fix/mcp-render-caption-separator
Draft

MacallanTheRoot wants to merge 1 commit into
storytold:mainfrom
MacallanTheRoot:fix/mcp-render-caption-separator

Conversation

@MacallanTheRoot

@MacallanTheRoot MacallanTheRoot commented Nov 14, 2026 •

Copy link
Copy Markdown

anicraft_render returns × between the stage width and height because the caption formatter contains that malformed literal. Replace it with the Unicode multiplication sign ×.

Extend the existing MCP render test to assert the complete caption (frame 3, scene 0, 25%, and 1280×720 stage), the successful image/text response structure, and a base64-decodable PNG that decodes to 320×180 pixels. Existing invalid-frame and invalid-scale assertions remain in place. No dependencies or unrelated files change.

The regression test was executed against the original implementation and failed specifically on 1280×720 versus 1280×720; it passes with the fix.

Validation:

  • cargo test -p anicraft-cli --locked: passed, 13 tests.
  • cargo test --workspace --no-default-features --locked --no-fail-fast: passed.
  • cargo clippy -p anicraft-cli --all-targets --locked -- -D warnings: passed.
  • cargo clippy --workspace --no-default-features --features gpu-stage --all-targets --locked -- -D warnings: passed.
  • git diff --check: passed.

Environment limitations:

  • Default-feature workspace tests, workspace Clippy, and the screenshot command cannot build because the ALSA development files (alsa.pc) are missing.
  • cargo fmt --all -- --check reports existing formatting differences. The changed file has identical rustfmt findings on upstream main and this branch; unrelated formatting is left untouched.
  • cargo deny check licenses bans sources cannot run because cargo-deny is not installed.
  • Workspace Clippy with all default features disabled reports six dead-code errors in unchanged src/gpu_watch.rs. Enabling gpu-stage while leaving sound disabled passes, as listed above.

Opened as a draft because default-feature and dependency-policy verification remain incomplete locally. After PR creation, CI, CI (macOS, Windows), Web, and SonarCloud all report action_required; no jobs or test results are available yet.

Fixes #311

@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(mcp): render caption contains a malformed stage-size separator

1 participant