Repository navigation
fix(mcp): correct render caption dimension separator - #337
Draft
MacallanTheRoot wants to merge 1 commit into
Draft
MacallanTheRoot wants to merge 1 commit into
MacallanTheRoot wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
anicraft_renderreturns×between the stage width and height because the caption formatter contains that malformed literal. Replace it with the Unicode multiplication sign×.Extend the existing MCP render test to assert the complete caption (frame 3, scene 0, 25%, and 1280×720 stage), the successful image/text response structure, and a base64-decodable PNG that decodes to 320×180 pixels. Existing invalid-frame and invalid-scale assertions remain in place. No dependencies or unrelated files change.
The regression test was executed against the original implementation and failed specifically on
1280×720versus1280×720; it passes with the fix.Validation:
cargo test -p anicraft-cli --locked: passed, 13 tests.cargo test --workspace --no-default-features --locked --no-fail-fast: passed.cargo clippy -p anicraft-cli --all-targets --locked -- -D warnings: passed.cargo clippy --workspace --no-default-features --features gpu-stage --all-targets --locked -- -D warnings: passed.git diff --check: passed.Environment limitations:
alsa.pc) are missing.cargo fmt --all -- --checkreports existing formatting differences. The changed file has identical rustfmt findings on upstream main and this branch; unrelated formatting is left untouched.cargo deny check licenses bans sourcescannot run because cargo-deny is not installed.src/gpu_watch.rs. Enablinggpu-stagewhile leaving sound disabled passes, as listed above.Opened as a draft because default-feature and dependency-policy verification remain incomplete locally. After PR creation, CI, CI (macOS, Windows), Web, and SonarCloud all report
action_required; no jobs or test results are available yet.Fixes #311