Repository navigation
ci: SonarCloud analysis from CI, like the other craft repos - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves this project from SonarCloud's automatic analysis to the shared
craft-common-actionsSonarCloud workflow, as the other repos use. Main and pull requests are then analysed on every push, instead of whenever automatic analysis next runs (it last ran here on 2026-11-10)..github/workflows/sonarcloud.yml: the same caller as craft-i18n. There's noCargo.toml, so the shared workflow skips its Rust coverage jobs and only scans.sonar-project.properties: project key and organization, `src` as sources and `test` as tests, and coverage excluded, because CI publishes no JS/TS coverage report and new code would otherwise always read 0%.storytold_discord-github-ticket-relayin SonarCloud (Administration › Analysis Method). While it's on, SonarCloud rejects CI scans, so this PR's own SonarCloud check fails until then.Coverage (updated): this PR now publishes real coverage instead of excluding it. The workflow runs
npm run test:coveragethrough the shared workflow's newnode-coverage-scriptinput (storytold/craft-common-actions#194), andsonar.javascript.lcov.reportPathspoints at the lcov report. Locally that comes to 79.0% line coverage over 131 source files (vitest with `@vitest/coverage-v8`). Until #194 merges, the workflow points at its branch (@sonarcloud/node-coverage), and it goes back to@mainbefore this merges.