Repository navigation
Conversation
…ntext) and Rust 1.99's chunks_exact_to_as_chunks lint Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…case on case-insensitive volumes On APFS/NTFS a.XMP answers for a.xmp, so a rename moved the user's a.xmp to Trip.XMP (and the sidecar fault-injection tests only passed on case-sensitive Linux). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…macOS 27 has no /bin/true), no non-UTF-8 names on APFS, Export dialog height with the Apple Photos row Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Withdrawing: these fixes already have open PRs for #989: #990/#994 (on_exit), #997 (clippy 1.99), #990 (/bin/true), #1003 (non-UTF-8 on APFS), #1018 (Export dialog height), #1007 (sidecar tests), and #1052/#1031 for the sidecar case bug (#1006). The two parts nobody else covers (a corpus-test fix for .DS_Store and a macOS CI workflow) go in a smaller PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maindidn't build on macOS, andcargo xtask cifailed there in several places that Linux and FreeBSD CI can't see.eframe::App::on_exit(self)after 0.5.0 crashes at startup on Windows 11 (DX12): Shader translation error 0x80070057 in egui_pipeline #812 added theglargument.chunks_exact_to_as_chunkslint inpipeline/src/spots.rs.a.XMPanswers fora.xmp, so renaming a photo moved the user'sa.xmptoTrip.XMP.rename.rsnow finds each sidecar's real on-disk name (MoveFs::spelling), keeps its extension case and moves it once. Regression test:sidecars_keep_their_extension_case_on_case_insensitive_volumes(fails without the fix). The fault-injection sidecar tests, which only passed on case-sensitive Linux, now pass on macOS..DS_Store). The lock test spawnstruefromPATH, since macOS 27 has no/bin/true. The Lightroom-folder test skips non-UTF-8 names that APFS refuses. The Export-dialog height test allows for the macOS-only "Add to Apple Photos" row (876 vs 846 pt).macos.ymlrunscargo xtask cionmacos-15for pushes tomainand for PRs. The corpus tests skip there because the runner has no corpus.cargo xtask cipasses locally on macOS 27 / Rust 1.99.Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com