Skip to content

Fix Save Changes dialog backdrop and interactions - #1646

Open
shlok2721-web wants to merge 11 commits into
storytold:mainfrom
shlok2721-web:fix/save-dialog-keyboard-focus
Open

shlok2721-web wants to merge 11 commits into
storytold:mainfrom
shlok2721-web:fix/save-dialog-keyboard-focus

Conversation

@shlok2721-web

Copy link
Copy Markdown

Summary

Fixes the Save Changes dialog's backdrop layering and dismissal behavior.

Changes

  • Dimmed backdrop: Adds a translucent backdrop behind the Save Changes dialog to visually distinguish it from the underlying application.
  • Click-outside dismissal: Allows clicking outside the dialog to dismiss the prompt.
  • Correct dialog layering: Ensures the Save Changes dialog and its buttons remain above the backdrop, so button clicks are handled correctly.
  • Regression test: Adds UI coverage verifying that clicking Save closes the prompt and writes the modified document to disk.
  • CI workflow: Updates the Linux build workflow to run relevant tests and improve build caching.

Testing

  • Built and manually tested the application; the affected behavior works as expected.
  • Added an automated regression test for the Save Changes button and document persistence.

Closes #1597

@fluorine

Copy link
Copy Markdown
Contributor

Issue #1597 is closed, and merged PR #1602 closed it. This PR may now be unnecessary. Please check whether main already has this change. If it does, please close this PR. If something is still missing, say what here.

This check is automatic and can be wrong.

🤖 Generated with Claude Code

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Do you want to save changes to ...' dialog starts as unfocussed

2 participants