cmake: Fix clang-format detection#288
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 31 31
Lines 2276 2276
=======================================
Hits 2218 2218
Misses 58 58 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detecting
clang-formaton Ubuntu 22.04 results in an empty version string since this flavor additionally adds the wordUbuntuto the beginning of the string to distinguish itself from the vanilla version. Fix our detection of the version string by allowing arbitrary strings before the important part that is actually parsed.