Skip to content

Add small fixes for bootstrap 3. Add tests.#85

Open
schneikai wants to merge 23 commits into
stouset:masterfrom
schneikai:master
Open

Add small fixes for bootstrap 3. Add tests.#85
schneikai wants to merge 23 commits into
stouset:masterfrom
schneikai:master

Conversation

@schneikai

Copy link
Copy Markdown

Hi,

I use this gem in a current Rails 4 project so I added some fixes to make it work better with Bootstrap 3. I also added tests for everything.

Details:
I removed the example code for inline. Correct me if I'm wrong but this wasn't TWBS 3 markup. Inline form elements in horizontal forms are also not mentioned in the Bootstrap docs so maybe we should remove this? If it should stay, I think the right markup would be to add a row container and add a column class to every form-group inside that row.

Also the date_select won't render 3 fields on one line without extra markup in TWBS 3 so the old screenshot is wrong. We would need to add extra css to make the 3 select inputs float or wrap them with a row and add column classes like for inline inputs.

Updated the height sizing classes to use input-sm instead of small.

Added the select element styling fix from #78

Updated the screenshot.

Comment thread .gitignore Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a project-specific .gitignore. Most of the entries in this seem to be specific to your development environment, and should be in ~/.gitignore.

@stouset

stouset commented Nov 19, 2013

Copy link
Copy Markdown
Owner

The example screenshot no longer has inline form fields, as it does in the original example image.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the double-nesting of the namespace?

@stouset

stouset commented Nov 19, 2013

Copy link
Copy Markdown
Owner

Outside of the comments, it looks good. Thanks.

@schneikai

Copy link
Copy Markdown
Author

About the inline form fields:
I removed the example code for inline. Correct me if I'm wrong but this wasn't TWBS 3 markup. Inline form elements in horizontal forms are also not mentioned in the Bootstrap docs so maybe we should remove this? If it should stay, I think the right markup would be to add a row container and add a column class to every form-group inside that row.

I could add it like this if you want to.

@stouset

stouset commented Nov 22, 2013

Copy link
Copy Markdown
Owner

If we can keep some way to have inline form fields, it would be great. Use your best judgment, though — if TB doesn't support anything like it now, and it looks like any approach would be likely to break in future updates, we should probably abandon it.

@stouset stouset mentioned this pull request Nov 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants