fix: support semicolon path separator for Windows compatibility in --sop-paths#51
Open
haosenwang1018 wants to merge 1 commit intostrands-agents:mainfrom
Open
Conversation
…sop-paths On Windows, using ':' as the path separator breaks paths with drive letters (e.g. C:\Users\...). This change makes expand_sop_paths() prefer ';' when present, falling back to os.pathsep otherwise. Backward compatible: existing Unix ':'-separated paths still work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
--sop-pathsuses:(colon) as the path separator, which conflicts with Windows drive letters likeC:\Users\sops. This causesexpand_sop_paths()to split incorrectly on Windows, resulting in broken paths.Solution
;(semicolon) as a cross-platform path separator;is present in the input string, split on;(safe for both Windows and Unix);is present, fall back toos.pathsep(:on Unix,;on Windows)Backward Compatibility
Existing Unix users passing
/path1:/path2are unaffected — the fallback toos.pathseppreserves the old behavior when no semicolons are present.