fix: preserve non-ASCII tool result text#2653
Open
cyphercodes wants to merge 1 commit into
Open
Conversation
This was referenced Jun 8, 2026
Contributor
|
Thanks for fixing the decorator path here! 🙏 Heads-up on scope: the provider-side This PR's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@toolresults returned as dictionaries or lists currently escape CJK and emoji characters because the standard JSON serializer defaults to ASCII escaping, while Pydantic model returns keep UTF-8 text. This keeps structured tool-result text human-readable regardless of whether a tool returns a dict, list, or model.Related Issues
Resolves #2636
Documentation PR
No documentation changes are needed for this bug fix.
Type of Change
Bug fix
Testing
uv run --extra dev pytest tests/strands/tools/test_decorator.py -vvuv run --extra dev ruff format --check src/strands/tools/decorator.py tests/strands/tools/test_decorator.pyuv run --extra dev ruff check src/strands/tools/decorator.py tests/strands/tools/test_decorator.pyuv run --extra dev mypy src/strands/tools/decorator.pyI ran
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.