Skip to content

design: add context management presets design doc#2756

Merged
lizradway merged 1 commit into
strands-agents:mainfrom
lizradway:lizradway/docs-design-sync-review
Jun 12, 2026
Merged

design: add context management presets design doc#2756
lizradway merged 1 commit into
strands-agents:mainfrom
lizradway:lizradway/docs-design-sync-review

Conversation

@lizradway

@lizradway lizradway commented Jun 12, 2026

Copy link
Copy Markdown
Member

Re-raises strands-agents/docs#831 in the monorepo format with v1 section updated to match the shipped implementation (harness-sdk#2643).

Description

Adds designs/0011-context-strategy.md — the context management presets design doc. This is the same content as strands-agents/docs#831, moved into the monorepo's designs/ directory with:

  • Monorepo metadata header (Status, Date, Issue, Related, Scope)
  • v1 section updated to reflect the actual shipped implementation: string-only "auto", InMemoryStorage, benchmark-validated defaults (maxResultTokens=1500, previewTokens=750, summaryRatio=0.3, compressionThreshold=0.85), and correct coexistence behavior
  • Python examples added alongside TypeScript throughout
  • v2 section preserved as-is (proposed, not yet implemented)

Related Issues

Documentation PR

N/A — this is a design doc, not user-facing documentation.

Type of Change

Other (please describe): Design document addition

Testing

This is a markdown design document — no code changes.

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have reviewed and understand every line of code in this PR, including any generated by AI tools, and I can explain why it works
  • My change is focused and reasonably small; I have split unrelated work into separate PRs
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Re-raises strands-agents/docs#831 in the monorepo format with v1
section updated to match the shipped implementation (harness-sdk#2643).
@github-actions github-actions Bot added chore Maintenance tasks, dependency updates, CI changes, refactoring with no user-facing impact area-context Session or context related documentation Documentation changes, improvements, additions, content updates, site improvements, examples, guides labels Jun 12, 2026
@lizradway lizradway marked this pull request as ready for review June 12, 2026 17:04
Comment thread designs/0011-context-strategy.md
Comment thread designs/0011-context-strategy.md
Comment thread designs/0011-context-strategy.md
Comment thread designs/0011-context-strategy.md
Comment thread designs/0011-context-strategy.md
@github-actions

Copy link
Copy Markdown
Contributor

Assessment: Request Changes

Well-structured, thorough design doc that fits the designs/ conventions nicely. However, the stated goal of this PR is to make the "v1" section match the shipped implementation, and that section currently contains several factual mismatches against the merged code that should be corrected before merge.

Review Categories
  • Accuracy (v1 vs. shipped code): The contextManager/context_manager Agent parameter described as shipped does not exist in either SDK — only the underlying ContextOffloader + SummarizingConversationManager building blocks are present, with no "auto" resolver. This is the most important item.
  • Default values: Three cited "benchmark-validated" defaults don't match the source (maxResultTokens 1500→2500, previewTokens 750→1000, compressionThreshold 0.85→0.7; summaryRatio=0.3 is correct). The PR description repeats the incorrect values.
  • Storage claim: storage is a required arg on the offloader, not a defaulted InMemoryStorage.
  • Metadata: Top-level Status: Proposed is ambiguous given the doc mixes shipped (v1) and proposed (v2) content.

The v2 design itself reads well and aligns with the SDK tenets — the requested changes are about keeping the "shipped" claims accurate.

@lizradway lizradway enabled auto-merge (squash) June 12, 2026 19:13
@lizradway lizradway merged commit 5d8c219 into strands-agents:main Jun 12, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-context Session or context related chore Maintenance tasks, dependency updates, CI changes, refactoring with no user-facing impact documentation Documentation changes, improvements, additions, content updates, site improvements, examples, guides size/l

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants