fix(litellm): generate toolUseId when missing from provider#2949
Open
chaynabors wants to merge 1 commit into
Open
fix(litellm): generate toolUseId when missing from provider#2949chaynabors wants to merge 1 commit into
chaynabors wants to merge 1 commit into
Conversation
github-actions
Bot
added
size/s
python
7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
opieter-aws
approved these changes
Jun 24, 2026
zastrowm
requested changes
Jun 25, 2026
| yield self.format_chunk({"chunk_type": "content_start", "data_type": "tool", "data": tool_deltas[0]}) | ||
| first_delta = tool_deltas[0] | ||
| if not first_delta.id: | ||
| first_delta.id = f"call_{uuid.uuid4()}" |
Member
There was a problem hiding this comment.
This looks like it fixes the tool_use side of the id, but how does the tool result get associated with the same tool use id? Do we have to pair up the tool result with the generated id? I'm a little concerned we're just trading one problem for another
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1262 with a clean rebase on current main.
LiteLLM returns null for the tool call id field on some providers, leaving toolUseId as None in the resulting event stream. The fix assigns a fresh call_ when the first tool delta arrives without an id, before the content_start chunk, so downstream consumers see a stable identifier. Behavior is unchanged whenever a provider supplies an id.
Refs #1262, fixes #1259.