fix(agent): release invocation lock only in throw mode#2954
Open
chaynabors wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
size/xs
python
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In UNSAFE_REENTRANT mode begin() never acquires the invocation lock, but stream_async's finally was calling release_lock() unconditionally and could release a lock owned by a concurrent direct tool call from _caller.py. Gating the release on ConcurrentInvocationMode.THROW makes the UNSAFE_REENTRANT path a no-op while leaving THROW behavior unchanged.
Fixes #2918.