This repository was archived by the owner on Jun 3, 2026. It is now read-only.
feat: export McpTool from package index#1108
Open
brianstrauch wants to merge 1 commit into
Open
Conversation
McpTool is already a public class in `tools/mcp-tool.ts`, but it isn't re-exported from the package index, so it's unreachable from outside the package: the `exports` field only whitelists `.`, and Node's subpath enforcement blocks any deeper imports. This makes it impossible to subclass McpClient (which is exported) and return McpTool instances from a custom `listTools()`, since the McpTool constructor reference isn't accessible. Surface McpTool alongside the other tool exports (FunctionTool, ZodTool, tool factory) so external code can construct it directly.
brianstrauch
had a problem deploying
to
manual-approval
GitHub Actions
Error
brianstrauch
had a problem deploying
to
manual-approval
GitHub Actions
Error
3 tasks
Collaborator
|
This repository has been merged into the strands-agents/harness-sdk monorepo and will be archived shortly. All new development happens there. If this PR is still relevant, please recreate it against the monorepo. The code now lives under Apologies for the disruption, and thank you for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
McpToolis already a public class intools/mcp-tool.ts, but it isn't re-exported from the package index, so it's unreachable from outside the package: theexportsfield only whitelists., and Node's subpath enforcement blocks any deeper imports. This makes it impossible to subclass McpClient (which is exported) and return McpTool instances from a customlistTools(), since the McpTool constructor reference isn't accessible.Note that the Python SDK exports this as
MCPAgentToolso this gives us compatibility.Related Issues
Documentation PR
Type of Change
New feature
Testing
How have you tested the change?
npm run checkChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.