regional algebra 'ra' new QSR#180
Merged
Merged
Conversation
gatsoulis
added
PR: ready for review
PR: in progress
and removed
PR: ready for review
labels
Contributor
Author
|
It's OK the failing. It's the mutliple test failing which is expected as it needs updating once the correctness of RA is validated. |
Member
|
Yep - seems to match the table fine. |
Contributor
Author
|
Thanks. Will merge then. |
gatsoulis
pushed a commit
that referenced
this pull request
Sep 22, 2015
regional algebra 'ra' new QSR
Member
|
When X meets Y, if you are using this for discrete time steps, you'll need to -1 from the end of one interval. I think it is OK if you are using it for continuous spatial intervals. |
Contributor
Author
|
I will open a separate issue. Depends on the unit step though as we discussed ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of Regional Algebra (
raunique id).Both 2D and 3D is supported but it is limited to only 2D at the moment due to a constraint posed by
QSR_Abstractclass.No point writing the unittests till it is confirmed that it works correctly.
If someone could test it therefore, I think @PDuckworth has experience with Allen relations and if you could please do it (hence assigned to him). If anyone also wants to test it please go ahead.
For the tests this table describing the relations might be of help.