feat: support signing arbitrary digests#306
Draft
rach-id wants to merge 9 commits into
Draft
Conversation
rach-id
commented
May 19, 2025
| @@ -1,4 +1,4 @@ | |||
| FROM golang:1.21-alpine AS build-env | |||
| FROM golang:1.24-alpine AS build-env | |||
Author
There was a problem hiding this comment.
I took the liberty to bump go to 1.24. If there is a reason you want to stick to 1.21, I can revert.
Comment on lines
+137
to
+138
| github.com/cometbft/cometbft => github.com/rach-id/cometbft v0.0.0-20250516082204-6749b21a5eeb | ||
| github.com/cosmos/cosmos-sdk => github.com/rach-id/cosmos-sdk v0.43.0-beta1.0.20250516083217-185fe1b3a89c |
Author
There was a problem hiding this comment.
These are temporary replaces. Once the changes are merged and released on comet side, we can change these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for signing arbitrary digests.
It provides the implementation for: cometbft/cometbft#5126 on the Horcrux side.
I opened this PR to get early feedback on the implementation. However, merging it depends on extending the cometBFT privval interface and releasing it.