Merged
Conversation
* labeling tweaks * remove the need to use the translate function when adding settings/controls via the helper method * separated all those settings and controls into their own helpers to make the register function easier to manage * resolved issue with missing color settings, need to update them to use helpers * put back missing color settings, updated helper * wordpress formatting * colors needed a little organizing too * Fixes based on co-pilot's PR review, added a stylesheet for customizer and some comments to functions that were missing any * new helpers for new sections in customizer, move some core sections into custom panels, re-organizing where settings live after feedback * panels/sections properly ordered via priority * colors in the correct order, a little styling * Wording tweaks; moving some settings around; Adding columns ratio to posts and blog separate setting inherits pages setting * Spaces > Tabs * Replacing webfonts with latin-extended versions for broader language support * Spaces > Tabs * Cleanup of line indentation * Reordering page settings * creating variables and converting arrays into functions while keeping filters intact - work in progress * breaking stuff * pause here before contemplating refactoring to class based, don't want to get too lost in the rabbit hole * commit before switching branches * resolved undefined error I was getting, cleaned up color/color scheme code with functions * Decided to create a new default based on the 4.6 one so we can group theme variation color schemes and separate legacy. Too many colors in legacy which can make styling tougher. * adding in hook I removed, thinking about how to call schemes from customizer file * slowly updating customizer js to keep old color scheme working * colors are saving on an individual level (overrides) for legacy but color scheme settings themselves are not saving the value... * migration function added so those on legacy color schemes can have their values preserved and the new color scheme setting will read 'leagacy' on it * kind of works, a bit funky * trying a different approach to color scheme handling, testing * removing old stuff * looks like it's working, needs regression testing * try adding a new color scheme as an example * only show existing dark mode setting if value is detected, we want to deprecate/replace this in the future * remove theme support for color palette, we don't need it * add styles to the editor stylesheet for fonts, update theme.json so buttons use body font, not heading font * adjust button styles a bit, added a pmpro setting to customizer to override pmpro colors with customizer colors * show pmpro color overrides in live preview * commit before I start breaking things while fixing default colors/overrides in the preview/front-end * formatting and comments * adding documentation for color schemes and presets * more documentation * updated JS to use get_theme_mod to check for legacy, adjusting sync function * commit before switching branches * do we even need to set default for new theme? * trying to fix default value loaded in customizer * corrections * it looks like it's working now PHP wise yay, just tweaking the JS for live preview * we're closer * see if I can get the legacy scheme permanently added as part of the new color scheme setting * working on individual color pickers * looks like it's mostly working on front-end and customizer except the site tagline * stable here before I add new color schemes from Kim * starting to clean up and update comments * cleaned up * bring over Kim's changes in the theme.json * formatting and updated docs * Merging dev * Removing additions to editor.css * initial attempt at documenting project structure * site tagline customizer fix, minor tweak to what CSS var headings use in styles * corrected some minor things that PHP Storm was complaining about, old web prefixes, incorrect values, redundant px etc. * corrected some old prefixes, incorrect values and redundancy in the stylesheet. Also added fixes mostly for headings that wasn't in the theme.json, need to organize keys better... * Fixing an incorrect background color relationship * Reverting some adjustments to a happy medium * Resolving if site title and tagline are hidden * Color scheme tweaking * Fix for header text color properly storing as WP intends * Updating color schemes * Filtering header and body font to theme.json like colors * paces to tabs --------- Co-authored-by: unknown <rachelrvasquez@gmail.com>
#202) * added back in code to trigger color overrides for the PMPro CSS vars, and using in header_output instead * formatting fix * Swap to use defined check like other related compat checks (for now); adjusting customizer CSS output to harden presence of hash in hex (we have other plans for this too); cleaning up CSS output --------- Co-authored-by: Kim Coleman <kim@strangerstudios.com>
* added back in code to trigger color overrides for the PMPro CSS vars, and using in header_output instead * formatting fix * in the process of removing hashes from all colors so we don't save them in the database * removed hashes from legacy scheme defs too, and updated the function in updates.php to save colors without the hashes * it seems like we do need the WP prefixed vars? Noticed some elements not pulling colors with undefined vars because they're using WordPress vars. Will test some more to ensure we really need this. * all colors save into the database without hashes, need to test migration script on a legacy scheme, there's some weirdness happening in the <head>. Will record a loom... * brought over Kim's changes * formatting * remove prefixed vars in header_output * rebased branch * added back in where we're checking PMPRO_VERSION * try to align comments in set_customizer_color_settings * try to align comments in set_customizer_color_settings * tweak to if else in the memberlite_migrate_colors_to_theme_mods for checking existing values vs new ones * put back a change I applied from co-pilot, better this way * Spaces to tabs --------- Co-authored-by: Kim Coleman <kim@strangerstudios.com>
* turn enlarge excerpt off by default * Coding standards; inline docs update --------- Co-authored-by: Kim Coleman <kim@strangerstudios.com>
* add docs folder to git attributes to exclude from export * Leading / not needed since folder is relative to .gitattributes --------- Co-authored-by: Kim Coleman <kim@strangerstudios.com>
…e palette in editor (#210) * Resolving issues with mapping colors to wp presets; new way to de-dupe palette in editor * Fixed some mismatched preset colors * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Ensuring we do not put the word 'blank' in the inline CSS * Resolved mapped color issues to match dev branch slugs * Moving color functionality to standalone file; creating the ultimate color mapping tool to be used everywhere possible as the single source of truth * Code formatting; adjusted button colors * Resolving potential issue with appending CSS via JS; fixing swap display of header text / site titel and tagline and colors from scheme --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…before saving to theme mods (#211) * adding logic to get color setting keys and trim hashes before saving into the theme mods, need to test * import works but we need to properly set color scheme * added functionality to set legacy color scheme to custom * fixes from PR feedback * update so imported scheme defaults to custom whether it's legacy or a malformed color scheme, otherwise, it should be a modern scheme * Now using the sanitize_hex_color_no_hash function to prep a color for import; lowercasing for consistency --------- Co-authored-by: Kim Coleman <kim@strangerstudios.com>
* Working on merging / consolidating colors and dark mode into main css * Streamlining colors, spacing, and sizing to theme.json * Color scheme more like the current Memberlite 6.1.1 default * Resolving issue with spacing; requiring theme.json version 2, not 3 yet * Fixing grid spacing / responsive * Expanding spacing for archive view * Continue styling stremlining * All the style improvements; eliminate the dark css file and theme mod; set root scheme as light or dark based on luminance of background color * Updating the updates db version (consolidating updates) * Discoveries in changes introduced while pull this to live PMPro site for testing * Resolving issue with update script and fallbacks present in dev * Fallbacks preserved for masthead and footer widgets * Fixing css error
* added simple build process so we can add custom settings * in the process of replacing conditionals where we check for the blank templat * created a small helper to get the post meta, swapped page template conditional with helper * delete blank template * separate hiding the header and footer into two separate toggles * add function to replace old post meta tied to the blank page template to the new post meta that matches our new settings * renamed existing docs to lowercase, moved the editor settings to it's own file in includes * added docs for the build process * return early if updates function doesn't find any pages with the blank template * changes based on co-pilot feedback, mainly re-naming functions and making the returns on the helpers clearer * fix to path in docs, return early if post type isn't a page in JS, remove the filters from helpers * return early if assets file doesn't exist for editor settings, add localization to editor settings JS * renamed function where we register post meta for settings, created a separate update file for memberlite 7.0 * remove interstitial template and any references in code to it, CSS is still there for backwards compatibility but added a comment * added a function to set post meta where the interstitial template was active for reference, no new setting added * corrected how I was adding the setting to the document settings for hiding prev/next on pages * removed checkbox in the metabox we'll be deprecating soon, and officially registered the existing post meta because the REST API needs to read it (the block editor) * update php doc comments * tweak comment on function to remove dark css theme mod after branch rebase * fixes based on more co-pilot feedback * tweak to meta login conditional * changes from PR feedback * added a comment to logic that shows page nav in content-page for clarity * Adjusting update script to handle swapping page template; New update script for fluid-width template to use template setting; putting latest color migration script in place before merge * Small wording change for editor panel * Incrementing db version so pre-release sites get the latest script run * Moving conditional page nav checks into the function --------- Co-authored-by: Kim Coleman <kim@strangerstudios.com>
…ign mobile nav (#215) * bringing over some code from when we first experimented with separating into components, added a customizer setting for footer style variation working on breaking down the header, a bit more tricky... still tinkering with the header, branch switch changed the theme mod name for the footer so we can use values to pull parts dynamically, updated the files so we can apply styles and switch template parts based on the footer theme mod formatting, branch switch * putting back code that may have gotten lost during the rebase * cleaning up the main header.php, renamed the meta template part to member info note, potentially remove ununsed functions remove sidebar 3 and meta nav from header * remove where we register sidebar-3 and the meta menu dial back the refactor for mobile, tackle separately, put mobile and site navigation near each other * move row class into templates rather than a complex conditional, hide masthead on single post so we can include the title in the article tag styling tweak for blog archive, fixed loop I broke * pause here on cleaning up * started adding a header variation * re-named templates for variations for clarity, created new files for breadcrumbs, featured image, realized the content template and content single are pretty much the same, moved into one template while leaving conditionals in, updated function name to standards * delete content-single template, add note to format templates that we intend to deprecate * sidebars and spacing above content should be consistent now * put back sidebar-3 and any related code, added hook to detect existing menus in the 'meta' location we're deprecating, separate template part for sidebar-3 * mobile styles, almost there - updating the styling and JS for a close button * mobile header re-design done for the moment * adjust current background color using the light-dark function, adjust aria attrs and focus for mobile * delete post format templates * delete variation templates for now, will work on variations separately, small footer style tweak * type cast and comments on new functions in template-tags file * changes based on co-pilot feedback * ensure existing hooks for single content and post content are present * spaces * styling fixes to mobile menu with search form on and member meta showing * version update * more header tweaks * update php version * delete breadcrumbs template part and call function directly, add early return for author's block * Fixing incorrect template part include naming * Fallback for renamed breadcrumbs function * Fixing incorrect theme support duplicates; adding new inc/variations.php file for variaiton functions * USing new function to get variation template part and wrap in selector based on variation * Fixing update script to bypass a hidden site title * Adding template part version in code comments; various adjustments to template parts * Fixing default color to match current default scheme * Tweaking styles for simplicity and light/dark bgs * Styling and layout improvements further to cleanup * Tightening up scheme compare logic * Removing unused file * Simplifying styles; adjusting mobile menu spacing to use spacing system; adjusting header right area spacing * Consistent selectors on meta member list items; wrapping header right "widgets" for flex styling * Fixing up things from Claude deep review * Simplifying WC overrides - we are pulling back on support for WC and will do the minimum here * WPCS * Removing a call for post meta that isn't managed in this box anymore * Fixing code comment ref to number of menus * WPCS * Version bump for dev sites and upgrade script bump * Removing legacy support for IE no longer needed * Version bump for testing * Fixing template part PHP call * Removing legacy PHP version check with version bump * sticky nav better handling * Removing incorrect duplicate selectors on page titles * More consistency for shadows; adjustments needed to RTL * Fix to exit early if member info not set; fixes log out still showing in all cases regardless of setting * Tweak a color scheme * Fixing logged out member info in mobile menu --------- Co-authored-by: Kim Coleman <kim@strangerstudios.com>
…ing grid blog layout bugs I created
* getting started on updating the customizer docs for 7.0 * my version of the docs before I ask AI to clean it up * cleaned up docs for customizer * deleted empty docs * tweak to function name * fix path to update file
* fix to social links * fix site title color * Apply suggestion from @kimcoleman --------- Co-authored-by: Kim Coleman <kim@strangerstudios.com>
… sure workflow has write permissions
Make sure php versions, theme versions match
… style.css, add null check for memberlite_maybe_show_deprecated_hook_message, translate aria label in mobile header file - all fixes from co-pilot feedback
Minor pre-launch 7.0 fixes
New workflow to build stylesheets on merge to the master branch
Pre launch 7.0 fixes
fix to footer widget link colors
fix to links and button colors, remove cocoa ash color scheme for now
Changelogs for 7.0 in readme.txt
…tributors to same entry
Memberlite 7 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Releasing Memberlite v7.0.