Skip to content

Installation Wizard: Don't prompt the user to install the PMPro Upgrade Manager if it's already active.#3522

Open
georgestephanis wants to merge 2 commits intostrangerstudios:devfrom
georgestephanis:install-wizard/advanced/remove-bit-if-unnecessary
Open

Installation Wizard: Don't prompt the user to install the PMPro Upgrade Manager if it's already active.#3522
georgestephanis wants to merge 2 commits intostrangerstudios:devfrom
georgestephanis:install-wizard/advanced/remove-bit-if-unnecessary

Conversation

@georgestephanis
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Add a conditional to the wizard so if the update manager is already installed and active, it doesn't prompt the user to install and activate it.

While this does mean that in the processing script it will try to install it, it will just short out as it's already active.

Unsure if it would be better to tweak this conditional to not rely on the constant from the update manager but do a is_plugin_active check. The constant would catch configurations where it lives in mu-plugins, but that's probably not ideal as it's harder to update.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Installation Wizard: Don't prompt the user to install the PMPro Upgrade Manager if it's already active.

@georgestephanis georgestephanis changed the title Install wizard/advanced/remove bit if unnecessary Installation Wizard: Don't prompt the user to install the PMPro Upgrade Manager if it's already active. Oct 23, 2025
@andrewlimaza andrewlimaza requested a review from Copilot December 12, 2025 11:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents the Installation Wizard from prompting users to install the PMPro Update Manager if it's already active on their site. The change improves the user experience by removing unnecessary prompts for plugins that are already installed and activated.

Key Changes:

  • Wraps the Update Manager installation prompt in a conditional check using defined( 'PMPROUM_VERSION' )
  • Fixes a minor spacing issue in a label attribute (for ="updatemanager"for="updatemanager")

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant