Installation Wizard: Don't prompt the user to install the PMPro Upgrade Manager if it's already active.#3522
Open
georgestephanis wants to merge 2 commits intostrangerstudios:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents the Installation Wizard from prompting users to install the PMPro Update Manager if it's already active on their site. The change improves the user experience by removing unnecessary prompts for plugins that are already installed and activated.
Key Changes:
- Wraps the Update Manager installation prompt in a conditional check using
defined( 'PMPROUM_VERSION' ) - Fixes a minor spacing issue in a label attribute (
for ="updatemanager"→for="updatemanager")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Add a conditional to the wizard so if the update manager is already installed and active, it doesn't prompt the user to install and activate it.
While this does mean that in the processing script it will try to install it, it will just short out as it's already active.
Unsure if it would be better to tweak this conditional to not rely on the constant from the update manager but do a
is_plugin_activecheck. The constant would catch configurations where it lives in mu-plugins, but that's probably not ideal as it's harder to update.Other information:
Changelog entry